Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalProperties to Entity #2648

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Conversation

EricDahlvang
Copy link
Member

Fixes #2561

@coveralls
Copy link

coveralls commented Aug 5, 2020

Pull Request Test Coverage Report for Build 154229

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.682%

Totals Coverage Status
Change from base Build 152653: 0.0%
Covered Lines: 14706
Relevant Lines: 16904

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Can you determine with @cleemullins if a test is applicable and either add the test to the PR or file a tracking issue for R11? (I’m in favor of doing the work in R11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity should allow custom fields
5 participants