[Engineering] Lower time for botbuilder-azure tests #2629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2338
Description
Updates the warnings raised in some tests of the BotBuilder-Azure library to be shown once for the describe instead of each test inside it.
Specific Changes
Update the tests in the files
blobStorage.test.js
andcosmosDbStorage.test.js
to run the emulator check once in the describes to raise a warning instead of running it in each test of the describe. This change reduces the time for the tests a little bit and makes the test report more readable.We also updated some eslint warnings in these files.
Testing
Here you can compare the times for each test running when moving the warning to be shown once for the describe and how it is more readable in the report.
Note: the times vary in each run, but in general there is a slight reduction in the times.