Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a typo in skill extensions #2581

Merged
merged 5 commits into from
Jul 28, 2020
Merged

Fixed a typo in skill extensions #2581

merged 5 commits into from
Jul 28, 2020
+16 −2

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Jul 27, 2020

Fixes #2580

Description

Fixed a typo in skill extensions.

Specific Changes

  • useSkillConverationIdFactory -> useSkillConversationIdFactory

Testing

@chon219 chon219 requested a review from a team as a code owner July 27, 2020 07:46
@chon219 chon219 self-assigned this Jul 27, 2020
@chon219 chon219 requested a review from Stevenic July 27, 2020 07:46
@coveralls
Copy link

coveralls commented Jul 27, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 150775

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.56%
Totals Coverage Status
Change from base Build 150757: 0.0%
Covered Lines: 14555
Relevant Lines: 16795
💛 - Coveralls

stevengum
stevengum approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This for fixing this and adding doc strings for the consts, can you add the params to the docstring for the static helper as well?

libraries/botbuilder-dialogs-adaptive/src/skillExtensions.ts Show resolved Hide resolved
@chon219 chon219 merged commit f0634b0 into master Jul 28, 2020
@chon219 chon219 deleted the zim/fix-skill-extensions-typo branch July 28, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhan2017 luhan2017 luhan2017 approved these changes

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees

@chon219 chon219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in Skill Extensions
4 participants
@chon219 @coveralls @stevengum @luhan2017