Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated HTTP request to parse binary response #2553

Merged
merged 5 commits into from
Jul 24, 2020
Merged

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Jul 21, 2020

Fixes #2459

Description

Refactored Http request action to parse binary data.

Specific Changes

  • Added binary response type
  • Parse binary response data in http request
  • Send trace info in http request

Testing

Updated test case for http request action.

@chon219 chon219 requested review from stevengum and a team as code owners July 21, 2020 12:50
@chon219 chon219 self-assigned this Jul 21, 2020
@coveralls
Copy link

coveralls commented Jul 21, 2020

Pull Request Test Coverage Report for Build 149918

  • 37 of 40 (92.5%) changed or added relevant lines in 1 file are covered.
  • 18 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.06%) to 81.566%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/actions/httpRequest.ts 37 40 92.5%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/actions/httpRequest.ts 2 81.63%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botbuilder-dialogs-adaptive/src/templates/textTemplate.ts 7 13.33%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 149867: -0.06%
Covered Lines: 13445
Relevant Lines: 15717

💛 - Coveralls

Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit c34ca98 into master Jul 24, 2020
@stevengum stevengum deleted the zim/http-request branch July 24, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] [Adaptive] Add Binary Data Parsing For Http Request
4 participants