Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return ResourceResponse from SkillHandler.processActivity #2489

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Return ResourceResponse from SkillHandler.processActivity #2489

merged 4 commits into from
Jul 13, 2020

Conversation

EricDahlvang
Copy link
Member

Fixes #2358

@EricDahlvang EricDahlvang requested a review from a team as a code owner July 7, 2020 16:59
@coveralls
Copy link

coveralls commented Jul 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 145960

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 81.036%
Totals Coverage Status
Change from base Build 145825: 0.08%
Covered Lines: 12999
Relevant Lines: 15310
💛 - Coveralls

@gabog gabog merged commit 50bc131 into master Jul 13, 2020
@gabog gabog deleted the eric/resourceResponseReturn branch July 13, 2020 21:45
@Batta32 Batta32 mentioned this pull request Jul 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@gabog gabog gabog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SkillHandler doesn't return ResourceResponse when forwarding activities (JS)
4 participants
@EricDahlvang @coveralls @gabog @stevengum