Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pipeline BotBuilder-JS-CI-node12-yaml #2487

Merged
merged 35 commits into from
Jul 7, 2020
Merged

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Jul 6, 2020

...and normalize botbuilder-js-ci.yml.
The pipeline: https://fuselabs.visualstudio.com/SDK_v4/_build?definitionId=1008&_a=summary
This satisfies issue #2331.

@BruceHaley BruceHaley requested a review from stevengum July 6, 2020 23:15
@BruceHaley BruceHaley requested a review from a team as a code owner July 6, 2020 23:15
@BruceHaley BruceHaley closed this Jul 6, 2020
@BruceHaley BruceHaley reopened this Jul 7, 2020
@coveralls
Copy link

coveralls commented Jul 7, 2020

Pull Request Test Coverage Report for Build 144025

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.607%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 143855: -0.07%
Covered Lines: 12979
Relevant Lines: 15377

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit c39c774 into master Jul 7, 2020
@stevengum stevengum deleted the v-bruhal/jsciyaml7-2b branch July 7, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants