Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional channel/chat lifecycle events #2471

Merged
merged 15 commits into from
Jul 24, 2020

Conversation

denscollo
Copy link
Contributor

Fixes #2367

Description

  • Add the following events to the teamsActivityHandler class.
    • teamArchived
    • teamDeleted
    • teamHardDeleted
    • teamRestored
    • teamUnarchived

Note: These changes can't be tested using MS-Teams until the implementation to use these events is done.

Specific Changes

  • Updated teamsActivityHandler class to add the following methods:

    • onTeamsTeamArchivedEvent.
    • onTeamsTeamDeletedEvent.
    • onTeamsTeamHardDeletedEvent.
    • onTeamsTeamRestoredEvent.
    • onTeamsTeamUnarchivedEvent.
  • Updated teamsActivityHandler.tests class to add the unit tests for the previous methods.

Testing

The next image shows the new tests passing:
image

- TeamArchived
- TeamDeleted
- TeamHardDeleted
- TeamRestored
- TeamUnarchived
@denscollo denscollo requested a review from a team as a code owner July 1, 2020 20:33
@denscollo denscollo requested a review from a team as a code owner July 14, 2020 20:07
@denscollo
Copy link
Contributor Author

@stevengum We just applied the feedback and merged with master

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see latest comments regarding test failures and TeamsActivityHandler end-of-file.

libraries/botbuilder/tests/teamsActivityHandler.test.js Outdated Show resolved Hide resolved
libraries/botbuilder/src/teamsActivityHandler.ts Outdated Show resolved Hide resolved
@denscollo
Copy link
Contributor Author

@stevengum feedback applied. Thanks!

@stevengum stevengum merged commit a8e7913 into microsoft:master Jul 24, 2020
@ceciliaavila ceciliaavila deleted the southworks/add/team-events branch July 24, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional channel/chat lifecycle events (JS)
3 participants