-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional channel/chat lifecycle events #2471
Merged
stevengum
merged 15 commits into
microsoft:master
from
southworks:southworks/add/team-events
Jul 24, 2020
Merged
Additional channel/chat lifecycle events #2471
stevengum
merged 15 commits into
microsoft:master
from
southworks:southworks/add/team-events
Jul 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TeamArchived - TeamDeleted - TeamHardDeleted - TeamRestored - TeamUnarchived
stevengum
requested changes
Jul 13, 2020
@stevengum We just applied the feedback and merged with master |
stevengum
reviewed
Jul 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see latest comments regarding test failures and TeamsActivityHandler end-of-file.
@stevengum feedback applied. Thanks! |
stevengum
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2367
Description
Note: These changes can't be tested using MS-Teams until the implementation to use these events is done.
Specific Changes
Updated teamsActivityHandler class to add the following methods:
Updated teamsActivityHandler.tests class to add the unit tests for the previous methods.
Testing
The next image shows the new tests passing: