Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open id metadata cache refresh if key is missing #2466

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Open id metadata cache refresh if key is missing #2466

merged 4 commits into from
Jul 1, 2020

Conversation

EricDahlvang
Copy link
Member

Fixes #2442

@EricDahlvang EricDahlvang requested a review from a team as a code owner July 1, 2020 17:27
stevengum
stevengum approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. :shipit:

@coveralls
Copy link

coveralls commented Jul 1, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 142780

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 80.971%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 142765: -0.06%
Covered Lines: 12963
Relevant Lines: 15289
💛 - Coveralls

@stevengum
Copy link
Member

@carlosscastro when you have the chance can you review this as well?

@EricDahlvang thanks for adding the test! 😄

@EricDahlvang EricDahlvang mentioned this pull request Jul 1, 2020
Closed
@EricDahlvang EricDahlvang merged commit 6fbbbbb into master Jul 1, 2020
@EricDahlvang EricDahlvang deleted the eric/openIdMetadataCache branch July 1, 2020 18:17
EricDahlvang added a commit that referenced this pull request Jul 1, 2020
@EricDahlvang
Open id metadata cache refresh if key is missing (#2466)
ee552b6 
* openIdMetadata cache updates and tests

* revert whitespace change

* copyright header for openIdMetadata.test.js
@EricDahlvang EricDahlvang mentioned this pull request Jul 1, 2020
Closed
EricDahlvang added a commit that referenced this pull request Jul 1, 2020
@EricDahlvang
Open id metadata cache refresh if key is missing (#2466) (#2469)
0df8af5 
* openIdMetadata cache updates and tests

* revert whitespace change

* copyright header for openIdMetadata.test.js
@EricDahlvang EricDahlvang mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosscastro carlosscastro carlosscastro approved these changes

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New OpenIdMetadata signing keys will not be picked up for up to 5 days
4 participants
@EricDahlvang @coveralls @stevengum @carlosscastro