Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert comments on Dialog.onDialogEvent() to TSDoc #2462

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Convert comments on Dialog.onDialogEvent() to TSDoc #2462

merged 2 commits into from
Jul 8, 2020

Conversation

mrestorff
Copy link
Contributor

Fixes #2413

Description

The inline documentation on Dialog.onDialogEvent() were still in docXML. Converted them to TSDoc.

Specific Changes

  • converted inline documentation on Dialog.onDialogEvent() to TSDoc

Testing

N/A

@mrestorff mrestorff requested a review from a team as a code owner July 1, 2020 09:59
@mrestorff mrestorff changed the title Convert comments on Dialog.onDialogEvent() to TSDoc #2413 Convert comments on Dialog.onDialogEvent() to TSDoc Jul 1, 2020
stevengum
stevengum approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@stevengum stevengum merged commit 9c56727 into microsoft:master Jul 8, 2020
@mrestorff mrestorff deleted the convertComments branch July 8, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert raw docXML to typedoc/jsdoc comment (Dialog.onDialogEvent method)
2 participants
@mrestorff @stevengum