Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aadGroupId to TeamInfo #2370

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Add aadGroupId to TeamInfo #2370

merged 3 commits into from
Jun 22, 2020

Conversation

EricDahlvang
Copy link
Member

Fixes #2354

@EricDahlvang EricDahlvang requested a review from a team as a code owner June 17, 2020 00:01
@coveralls
Copy link

coveralls commented Jun 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 139939

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 80.882%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 139921: -0.06%
Covered Lines: 12899
Relevant Lines: 15229
💛 - Coveralls

stevengum
stevengum approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit a7e4f82 into master Jun 22, 2020
@EricDahlvang EricDahlvang deleted the eric/addAadGroupId branch June 22, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TeamInfo type does not expose aadGroupId (js)
3 participants
@EricDahlvang @coveralls @stevengum