Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ValueRcognizer internal #2347

Merged
merged 5 commits into from
Jul 2, 2020
Merged

Make ValueRcognizer internal #2347

merged 5 commits into from
Jul 2, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Jun 15, 2020

Fixes #2078

Description

Unregistered Microsoft.ValueRecognizer and make it internal.

Specific Changes

  • Unregistered ValueRecognizer in component registration
  • Updated adaptive dialog to have a built in value recognizer
  • Fixed RecognizerSet to merge all properties from recognized entities from child recognizers

Testing

Updated test cases to reflect new changes.

@chon219 chon219 requested review from Stevenic and stevengum June 15, 2020 06:57
@chon219 chon219 self-assigned this Jun 15, 2020
@coveralls
Copy link

coveralls commented Jun 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 143052

  • 29 of 30 (96.67%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 81.041%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/recognizers/recognizerSet.ts 18 19 94.74%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/recognizers/recognizerSet.ts 1 93.75%
Totals Coverage Status
Change from base Build 142935: 0.08%
Covered Lines: 12982
Relevant Lines: 15303
💛 - Coveralls

@chon219 chon219 mentioned this pull request Jun 23, 2020
Closed
@chon219 chon219 merged commit 5a00507 into master Jul 2, 2020
@chon219 chon219 deleted the zim/value-recognizer branch July 2, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhan2017 luhan2017 luhan2017 approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@stevengum stevengum Awaiting requested review from stevengum

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

@chrimc62 chrimc62 Awaiting requested review from chrimc62

Assignees

@chon219 chon219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] Make ValueRecognizer internal
3 participants
@chon219 @coveralls @luhan2017