Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nested foreach/foreachpage #2306

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Allow nested foreach/foreachpage #2306

merged 4 commits into from
Jun 9, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Jun 4, 2020

Fixes #2021

Description

Allow ForEach and ForEachPage to be nested.

Specific Changes

  • Configurable value and index in ForEach
  • Configurable page and pageIndex in ForEachPage

Testing

Added test case to test nested ForEach
Added test case to test nested ForEachPage

@chon219 chon219 requested review from Stevenic and stevengum June 4, 2020 09:40
@chon219 chon219 self-assigned this Jun 4, 2020
@coveralls
Copy link

coveralls commented Jun 4, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 136751

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 80.943%
Totals Coverage Status
Change from base Build 136749: 0.004%
Covered Lines: 12811
Relevant Lines: 15115
💛 - Coveralls

@chon219 chon219 merged commit 2abb9ee into master Jun 9, 2020
@chon219 chon219 deleted the zim/nested-foreach branch June 9, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhan2017 luhan2017 luhan2017 approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@stevengum stevengum Awaiting requested review from stevengum

Assignees

@chon219 chon219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] Fix foreach issue and update some schema examples
3 participants
@chon219 @coveralls @luhan2017