Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do NOT call TeamsInfo.getMember for the bot #2237

Merged
merged 2 commits into from
May 14, 2020

Conversation

EricDahlvang
Copy link
Member

@EricDahlvang EricDahlvang commented May 14, 2020

Fixes: #2233

@EricDahlvang
Copy link
Member Author

Investigating ... these tests are passing locally:
image

But failing in the build pipeline:

 1) TeamsInfo
       getMember()
         should work without a Team:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(fetchExpectation.isDone())

      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (libraries/botbuilder/tests/teamsInfo.test.js:406:13)


  2) TeamsInfo
       getMember()
         should work with a Team:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(fetchExpectation.isDone())

      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (libraries/botbuilder/tests/teamsInfo.test.js:429:13)

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricDahlvang EricDahlvang merged commit 923f610 into 4.9 May 14, 2020
EricDahlvang pushed a commit that referenced this pull request May 14, 2020
* Do NOT call TeamsInfo.getMember for the bot

* fix failing TeamsInfo tests
@EricDahlvang EricDahlvang deleted the eric/fixonTeamsMembersAdded branch May 14, 2020 18:42
EricDahlvang pushed a commit that referenced this pull request May 14, 2020
* Do NOT call TeamsInfo.getMember for the bot

* fix failing TeamsInfo tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants