Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Expression] Remove dependency of Moment type in public methods #2232

Merged
merged 18 commits into from
Jul 3, 2020
Merged

[Expression] Remove dependency of Moment type in public methods #2232

merged 18 commits into from
Jul 3, 2020

Conversation

cosmicshuai
Copy link
Contributor

fixes: #2158
remove dependency of Moment type in timeTransform and parseTimestamp methods

@coveralls
Copy link

coveralls commented May 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 143283

  • 27 of 27 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 81.035%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/expressionFunctions.ts 2 89.08%
Totals Coverage Status
Change from base Build 143084: -0.006%
Covered Lines: 12983
Relevant Lines: 15306
💛 - Coveralls

@cosmicshuai cosmicshuai requested a review from stevengum May 13, 2020 09:37
@Danieladu Danieladu added the R10 Release 10 - August 17th, 2020 label May 14, 2020
@stevengum stevengum self-assigned this May 14, 2020
@stevengum stevengum requested a review from Zerryth May 18, 2020 18:38
@Danieladu
Copy link
Contributor

LGTM. @stevengum any more comments?

chrimc62
chrimc62 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cosmicshuai cosmicshuai merged commit db6d820 into master Jul 3, 2020
@cosmicshuai cosmicshuai deleted the shuwan/decoupleMoment branch July 3, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrimc62 chrimc62 chrimc62 approved these changes

@Danieladu Danieladu Danieladu approved these changes

@boydc2014 boydc2014 boydc2014 approved these changes

@stevengum stevengum Awaiting requested review from stevengum

@Zerryth Zerryth Awaiting requested review from Zerryth

@luhan2017 luhan2017 Awaiting requested review from luhan2017

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees

@stevengum stevengum

Labels
R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExpressionFunctions.timeTransform shouldn't directly rely on moment.Moment
6 participants
@cosmicshuai @coveralls @Danieladu @boydc2014 @chrimc62 @stevengum