Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'state' to AppBasedLinkQuery (for teams auth flow during link unfurling) #2194

Merged
merged 2 commits into from
May 15, 2020
Merged

Add 'state' to AppBasedLinkQuery (for teams auth flow during link unfurling) #2194

merged 2 commits into from
May 15, 2020

Conversation

EricDahlvang
Copy link
Member

Fixes #2026

@EricDahlvang EricDahlvang added the R10 Release 10 - August 17th, 2020 label May 6, 2020
@coveralls
Copy link

coveralls commented May 6, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 131438

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.263%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 131436: -0.07%
Covered Lines: 12684
Relevant Lines: 15087
💛 - Coveralls

@stevengum stevengum merged commit a5cd037 into master May 15, 2020
@stevengum stevengum deleted the eric/addStateToAppBasedLinkQuery branch May 15, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@benbrown benbrown Awaiting requested review from benbrown

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] Add state to AppBasedLinkQuery for OAuth flow
3 participants
@EricDahlvang @coveralls @stevengum