Style: Async method nomenclature, missing ConfigureAwait and CancellationTokens #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosscastro
requested review from
boydc2014,
chrimc62,
cleemullins,
gabog,
johnataylor,
mrivera-ms and
tomlm
as code owners
This was referenced May 8, 2020
Merged
Closed
johnataylor
suggested changes
May 8, 2020
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/DeleteProperty.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/DeleteProperties.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/EditArray.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/TriggerSelector.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs.Declarative/Resources/FileResource.cs
Show resolved
Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs.Declarative/Resources/ResourceExplorer.cs
Show resolved
Hide resolved
| @@ -388,7 +388,7 @@ public async Task<JToken> ResolveRefAsync(JToken refToken, SourceContext sourceC | |||
| } | |||
| } | |||
|
|
|||
| var (json, range) = await ReadTokenRangeAsync(resource, sourceContext); | |||
| var (json, range) = await ReadTokenRangeAsync(resource, sourceContext).ConfigureAwait(false); | |||
There was a problem hiding this comment.
cancellation token
#Resolved
| @@ -53,7 +54,24 @@ protected virtual string GetInternalVersion() | |||
| /// | |||
| /// This should be called at the start of `beginDialog()`, `continueDialog()`, and `resumeDialog()`. | |||
| /// </remarks> | |||
| protected virtual async Task CheckForVersionChangeAsync(DialogContext dc) | |||
| protected virtual Task CheckForVersionChangeAsync(DialogContext dc) | |||
There was a problem hiding this comment.
this is a bit weird - why not plumb through the cancellation
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh because it is in the dialogs assembly and it is abreaking change to binary level backward compat
There was a problem hiding this comment.
|
Thanks @johnataylor ! Code analisys detects ConfigureAwait and async names but not cancellation tokens so it's more manual. Appreciate the detailed review, new iteration incoming |
johnataylor
approved these changes
May 8, 2020
cleemullins
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3889