Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++ c#] Remove Bond Comm #827

Merged
merged 5 commits into from
Mar 20, 2018
Merged

[c++ c#] Remove Bond Comm #827

merged 5 commits into from
Mar 20, 2018

Conversation

chwarr
Copy link
Member

@chwarr chwarr commented Mar 14, 2018

Closes #824

tstein
tstein approved these changes Mar 14, 2018
View reviewed changes
Copy link
Contributor

@tstein tstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing some removals from the docs, too. Up to you whether to include that in this PR.

@chwarr
Copy link
Member Author

chwarr commented Mar 15, 2018

Something went wrong during a rebase and a bunch of comm stuff has been resurrected. Let me clean that up.

@chwarr
Copy link
Member Author

chwarr commented Mar 15, 2018

@ara-ayvazyan, @tstein: I think I fixed up the left over Comm bits from the bad rebase. Please review anew.

@chwarr
Copy link
Member Author

chwarr commented Mar 15, 2018

Looks like AppVeyor isn't running because I touched .travis.yml...

@tstein
Copy link
Contributor

tstein commented Mar 15, 2018

I was referring to the docs in doc/src/, where there several marksdown with comm in their filenames and probably some references in others. I think they've escaped this change so far.

@chwarr
Copy link
Member Author

chwarr commented Mar 15, 2018

Deleted the comm Markdown files. Thanks!

@tstein tstein merged commit 3221200 into microsoft:master Mar 20, 2018
@chwarr chwarr deleted the chwarr/rm-comm branch April 5, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstein tstein tstein approved these changes

@ara-ayvazyan ara-ayvazyan ara-ayvazyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chwarr @tstein @ara-ayvazyan