Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[travis c++] Compile with Boost 1.65.1 and GCC #677

Merged
merged 3 commits into from
Oct 30, 2017
Merged

[travis c++] Compile with Boost 1.65.1 and GCC #677

merged 3 commits into from
Oct 30, 2017

Conversation

ara-ayvazyan
Copy link
Contributor

No description provided.

@ara-ayvazyan ara-ayvazyan requested review from tstein and chwarr October 27, 2017 22:40
tstein
tstein reviewed Oct 27, 2017
View reviewed changes
Copy link
Contributor

@tstein tstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is fine, but BOOST... COMPILER seems backwards to me. Any thoughts about reversing the matrix and sorting by compiler first, and reversing the arguments and passing $COMPILER $BOOST?

@chwarr chwarr changed the title [travis c++] Compile Boost 1.65.1 with GCC [travis c++] Compile with Boost 1.65.1 and GCC Oct 27, 2017
chwarr
chwarr approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@chwarr chwarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit message, we'll want to talk about the plan to only build some representative configurations on each PR/commit and that the fuller matrix will be built with the cron jobs you suggested in issue #666.

@ara-ayvazyan
Copy link
Contributor Author

@tstein, I agree, but this will require changes in build_bond.zsh so that it accepts named parameters. Will keep this way for now, and I've added #678 to address it separately.

@chwarr chwarr merged commit 0d77c2f into microsoft:master Oct 30, 2017
@ara-ayvazyan ara-ayvazyan deleted the travis_use_gcc branch October 30, 2017 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstein tstein tstein left review comments

@chwarr chwarr chwarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ara-ayvazyan @tstein @chwarr