Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppVeyor to know about VS 2019 #1039

Merged
merged 2 commits into from
May 16, 2020
Merged

Conversation

bhardwajs
Copy link
Contributor

Update AppVeyor to know about VS 2019.

Fixes #1038

Copy link
Member

@chwarr chwarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few ValidateSet attributes that also needed to be updated. I've revised them in ceb1d1a.

I think the layout of the Boost packages has changed in later versions, so the Install-Boost.ps1 script may no longer work. However, we don't need this fixed to unblocked AppVeyor, if I'm reading the error correctly.

:shipit:

@bhardwajs
Copy link
Contributor Author

@chwarr Yeah, the build passed. So, the ValidateSet changes were needed as well. You got to fixing it before I could take a look. Thanks!

@chwarr chwarr merged commit d7557f2 into microsoft:master May 16, 2020
@bhardwajs bhardwajs deleted the patch-1 branch May 17, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppVeyor builds failing: "Unknown image name 'Visual Studio 2019'"
2 participants