Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::ptr_fun deprecatd in C++11 and removed in C++17 #1080

Closed
jpg85 opened this issue Dec 15, 2020 · 1 comment · Fixed by #1081
Closed

std::ptr_fun deprecatd in C++11 and removed in C++17 #1080

jpg85 opened this issue Dec 15, 2020 · 1 comment · Fixed by #1081
Labels
enhancement

Comments

@jpg85
Copy link

jpg85 commented Dec 15, 2020

bond/python/inc/bond/python/converters.h

Line 81 in 05c5798

std::replace_if(_name.begin(), _name.end(), std::not1(std::ptr_fun(isalnum)), '_');

Function should be replaced with alternative. Since boost is already being used, "boost::ptr_fun" should be a direct replacement.
chwarr added a commit to chwarr/bond that referenced this issue Dec 15, 2020
@chwarr
[c++] [python] Replace deprecated std::ptr_fun
7449c72 
`std::ptr_fun` is deprecated in C++11 and removed in C++17.

Replace its one use with a lambda.

Fixes microsoft#1080
@chwarr chwarr mentioned this issue Dec 15, 2020
Merged
@chwarr
Copy link
Member

chwarr commented Dec 15, 2020

Looks like a lambda works too. Proposed fix is in PR.

chwarr added a commit that referenced this issue Dec 16, 2020
@chwarr
[c++] [python] Replace deprecated std::ptr_fun
a8a56e9 
`std::ptr_fun` is deprecated in C++11 and removed in C++17.

Replace its one use with a lambda.

Fixes #1080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[c++] [python] Replace deprecated std::ptr_fun chwarr/bond
2 participants
@chwarr @jpg85