Create reference point for v4.0.0 rc4 #811
Conversation
shaopeng-gh
requested review from
michaelcfanning and
marmegh
as code owners
| @@ -4,9 +4,9 @@ namespace Microsoft.CodeAnalysis.IL | |||
| { | |||
| public static class VersionConstants | |||
There was a problem hiding this comment.
@shaopeng-gh Agree. Please update the release process.
|
|
||
| set MAJOR=2 |
There was a problem hiding this comment.
@shaopeng-gh I am confused at this point. The current internal version is 4.0.0-rc3 correct? Then why should we have changed it to 4 before this PR? It seems what you have done here is correct.
There was a problem hiding this comment.
yes, this was missed in the previous PR, we should have changed it at that time.
|
@shaopeng-gh Please don't leave the PR description blank. In reply to: 1433423241 |
|
|
||
| set MAJOR=2 |
There was a problem hiding this comment.
@shaopeng-gh I am confused at this point. The current internal version is 4.0.0-rc3 correct? Then why should we have changed it to 4 before this PR? It seems what you have done here is correct.
| @@ -99,7 +99,7 @@ public void AnalyzingTarget(IAnalysisContext context) | |||
| { | |||
| } | |||
|
|
|||
| public void Log(ReportingDescriptor rule, Result result) | |||
| public void Log(ReportingDescriptor rule, Result result, int? extensionIndex = null) | |||
There was a problem hiding this comment.
@shaopeng-gh What does this change do? Please provide some additional details via PR comments. #Resolved
There was a problem hiding this comment.
This is due to a breaking change that add a optional parameter:
BRK: Add ToolComponent argument to IAnalysisLogger.Log(ReportingDescriptor, Result) method. microsoft/sarif-sdk#2611
| @@ -4,9 +4,9 @@ namespace Microsoft.CodeAnalysis.IL | |||
| { | |||
| public static class VersionConstants | |||
There was a problem hiding this comment.
@shaopeng-gh Agree. Please update the release process.
src/ReleaseHistory.md
Outdated
| ## **v4.0.0-rc5** UNRELEASED | ||
|
|
||
| ## **v4.0.0-rc4** | ||
| * DEP: Update Sarif.Sdk submodule from [235394a to ec93dccd](https://github.com/microsoft/sarif-sdk/compare/235394a...ec93dccd). Full [SARIF SDK Release History](https://github.com/microsoft/sarif-sdk/blob/ec93dccd/src/ReleaseHistory.md). |
There was a problem hiding this comment.
@shaopeng-gh Note that Mike's PR on threading fixes got merged: microsoft/sarif-sdk#2618
So we should update the sarif-sdk submodule to reference the appropriate point in main. #Resolved
There was a problem hiding this comment.
Updated to latest main.
| @@ -42,7 +42,7 @@ public void AnalyzingTarget(IAnalysisContext context) | |||
| { | |||
| } | |||
|
|
|||
| public void Log(ReportingDescriptor rule, Result result) | |||
| public void Log(ReportingDescriptor rule, Result result, int? extensionIndex = null) | |||
There was a problem hiding this comment.
@shaopeng-gh Again, unclear what this change does. #Closed
|
added. In reply to: 1433423241 |
Create reference point for v4.0.0 rc4 without actual release.