Enable shadow-stack #376
Merged
Enable shadow-stack #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating shadowstack logic Removing debugging files Improving message strings Updating tests
eddynaka
force-pushed
the
users/ednakamu/shadow-stack
branch
from
4c801a5 to
11181e0
Compare
shaopeng-gh
reviewed
May 21, 2021
| AnalysisApplicability result = AnalysisApplicability.NotApplicableToSpecifiedTarget; | ||
|
|
||
| reasonForNotAnalyzing = MetadataConditions.ImageIsILOnlyAssembly; | ||
| if (portableExecutable.IsILOnly) { return result; } |
There was a problem hiding this comment.
other way is to move the assign statement inside the
if() {assign statement;return result; }
since it is only needed when if is true
#Resolved
There was a problem hiding this comment.
pls, do the proper changes :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277