Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: include go.env in GOROOT #8004

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Feb 21, 2024

Signed-off-by: Muhammad Falak R Wani [email protected]

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Include go.env in GOROOT which is now the default value from where GOPROXY value is read

Change Log
  • Include go.env in GOROOT
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
  • NA
Test Methodology

Signed-off-by: Muhammad Falak R Wani <[email protected]>
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Feb 21, 2024
@mfrw mfrw marked this pull request as ready for review February 21, 2024 21:15
@mfrw mfrw requested a review from a team as a code owner February 21, 2024 21:15
@mfrw mfrw merged commit b9c36e2 into main Feb 21, 2024
11 checks passed
@mfrw mfrw deleted the mfrw/golang-1.21.6-include-go.env branch February 21, 2024 21:41
@mfrw mfrw mentioned this pull request Feb 22, 2024
12 tasks
jslobodzian pushed a commit that referenced this pull request Feb 22, 2024
Signed-off-by: Muhammad Falak R Wani <[email protected]>
@mfrw mfrw mentioned this pull request Mar 7, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants