Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Ubuntu requirements doc with better Golang instructions. #6348

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Oct 4, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Our Ubuntu prerequisites instructions were outdate and mentioned Ubuntu 18.04, while the current tested and supported version is 22.04. We're also switching the instructions to suggest the official Ubuntu repo to download Go.

Change Log
Does this affect the toolchain?

No.

Associated issues
Test Methodology
  • N/A.

@PawelWMS PawelWMS requested a review from a team as a code owner October 4, 2023 23:47
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Oct 4, 2023
@PawelWMS PawelWMS merged commit aafec95 into microsoft:main Oct 5, 2023
@PawelWMS PawelWMS deleted the pawelwi/prerequisites_doc_update branch October 5, 2023 23:53
mbykhovtsev-ms pushed a commit to mbykhovtsev-ms/CBL-Mariner that referenced this pull request Oct 9, 2023
…rosoft#6348)

* Updating Ubuntu requirements doc.

* Adding missed Go version update.
gmileka pushed a commit that referenced this pull request Oct 11, 2023
* Updating Ubuntu requirements doc.

* Adding missed Go version update.
anphel31 pushed a commit that referenced this pull request Oct 13, 2023
* Updating Ubuntu requirements doc.

* Adding missed Go version update.
anphel31 added a commit that referenced this pull request Oct 13, 2023
…) (#6419)

* Updating Ubuntu requirements doc.

* Adding missed Go version update.

Co-authored-by: Pawel Winogrodzki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants