-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required indicators to fields #25992
Add required indicators to fields #25992
Conversation
* Add CodeQL Analysis workflow * Fix path
@microsoft-github-policy-service agree company="Microsoft" |
Pull Request Test Coverage Report for Build 11927586156Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@akshika898 , can you add before pictures? |
{ value: this._networkShareTargetDatabaseNames[index] }, | ||
{ value: this._networkShareLocations[index] }]); | ||
await this._networkShareTargetDatabaseNamesTable.setDataValues(networkShareTargetData); | ||
await this._networkShareTargetDatabaseNamesTable.setDataValues([ | ||
networkShareTargetTableHeaderComponents.map(component => ({ value: component })), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will lead to another accessibility issue since now table headers won't be announced as table headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this way as we do not have an option to give indicators in headers. Adding * as text was not a very good way and it would be shown in black which will be different from other indicators in extension leading to inconsistency in UI.
I understand that the header is now defined as row but even in previous version the tab did not go to headers, neither the narrator defined specifically for headers, nor I found error in accessibility insights. Do we have any other way to test it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, merging this as a temporary fix.
Added @aasimkhan30 |
Added required indicator in sql migration extension experience:
Linked issue: #25919
Task link: https://dev.azure.com/msdata/Database%20Systems/_workitems/edit/3563160
Fix:
Before:
After: