Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required indicators to fields #25992

Conversation

akshika898
Copy link
Contributor

@akshika898 akshika898 commented Oct 23, 2024

Added required indicator in sql migration extension experience:

  1. For subscription field
  2. For database backup fields

Linked issue: #25919
Task link: https://dev.azure.com/msdata/Database%20Systems/_workitems/edit/3563160

Fix:

Before:

image image image

After:
image

image image

@akshika898
Copy link
Contributor Author

@akshika898 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@coveralls
Copy link

coveralls commented Oct 23, 2024

Pull Request Test Coverage Report for Build 11927586156

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 78 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.003%) to 41.715%

Files with Coverage Reduction New Missed Lines %
extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseQuickpick.ts 6 83.64%
extensions/sql-database-projects/src/controllers/projectController.ts 72 39.3%
Totals Coverage Status
Change from base Build 11467144417: 0.003%
Covered Lines: 30722
Relevant Lines: 68916

💛 - Coveralls

@aasimkhan30
Copy link
Contributor

@akshika898 , can you add before pictures?

{ value: this._networkShareTargetDatabaseNames[index] },
{ value: this._networkShareLocations[index] }]);
await this._networkShareTargetDatabaseNamesTable.setDataValues(networkShareTargetData);
await this._networkShareTargetDatabaseNamesTable.setDataValues([
networkShareTargetTableHeaderComponents.map(component => ({ value: component })),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will lead to another accessibility issue since now table headers won't be announced as table headers.

Copy link
Contributor Author

@akshika898 akshika898 Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this way as we do not have an option to give indicators in headers. Adding * as text was not a very good way and it would be shown in black which will be different from other indicators in extension leading to inconsistency in UI.
I understand that the header is now defined as row but even in previous version the tab did not go to headers, neither the narrator defined specifically for headers, nor I found error in accessibility insights. Do we have any other way to test it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, merging this as a temporary fix.

@akshika898
Copy link
Contributor Author

akshika898 commented Oct 28, 2024

@akshika898 , can you add before pictures?

Added @aasimkhan30

@akshika898 akshika898 merged commit 9e02eb3 into microsoft:main Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants