Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Fabric SQL Mirrored support to the SQL Projects #25772

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Adding Fabric SQL Mirrored support to the SQL Projects #25772

merged 5 commits into from
Jul 25, 2024

Conversation

ssreerama
Copy link
Contributor

@ssreerama ssreerama commented Jul 24, 2024 •
edited
Loading

This PR adds the sql fabric database support to the sql projects extension. And also updating the BuildSdk version to 0.2.0-perview that supports the fabric platform.
image
image

@ssreerama ssreerama added this to the July 2024 Release milestone Jul 24, 2024
@ssreerama ssreerama linked an issue Jul 24, 2024 that may be closed by this pull request
SQL Fabric platform Support to the SQL Projects #25773
Closed
@ssreerama ssreerama self-assigned this Jul 24, 2024
@chlafreniere chlafreniere changed the title Adding SQL Fabric support to the SQL Projects Adding Fabric SQL Mirrored support to the SQL Projects Jul 24, 2024
@coveralls
Copy link

coveralls commented Jul 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10098152752

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 7 (42.86%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.007%) to 41.733%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/sql-database-projects/src/common/utils.ts 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePathPage.ts 3 58.43%
extensions/sql-database-projects/src/common/utils.ts 4 68.3%
Totals Coverage Status
Change from base Build 10083143139: -0.007%
Covered Lines: 30726
Relevant Lines: 68900
💛 - Coveralls

llali
llali reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@llali llali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about here?

azuredatastudio/extensions/sql-database-projects/src/common/utils.ts

Line 734 in 88392e1

if (engineEdition === azdataApi.DatabaseEngineEdition.SqlOnDemand) {
when it sets the target platform based on the edition id?

@llali
Copy link
Member

llali commented Jul 24, 2024

please verify the new project with the new platform can be created and deployed successfully.

@ssreerama
Copy link
Contributor Author

ssreerama commented Jul 24, 2024 •
edited
Loading

@llali , according to the comment "Update this when Fabric DW gets its own engine edition", we need to add the condition when Sql Fabric has the edition number, As per the docs I don't see the engine edition for the fabric. That's why left as is. https://learn.microsoft.com/en-us/sql/t-sql/functions/serverproperty-transact-sql?view=sql-server-ver16#:~:text=data%20type%3A%20bigint-,EngineEdition,-Database%20Engine%20edition

@llali
Copy link
Member

llali commented Jul 24, 2024

@llali , according to the comment "Update this when Fabric DW gets its own engine edition", we need to add the condition when Sql Fabric has the edition number, As per the docs I don't see the engine edition for the fabric. That's why left as is. https://learn.microsoft.com/en-us/sql/t-sql/functions/serverproperty-transact-sql?view=sql-server-ver16#:~:text=data%20type%3A%20bigint-,EngineEdition,-Database%20Engine%20edition

it is 12. we use it in dacfx

@ssreerama ssreerama requested a review from alanrenmsft as a code owner July 25, 2024 15:06
@ssreerama
Copy link
Contributor Author

@dzsquared , do we have the engine edition number for SqlDwUnified?

kisantia
kisantia approved these changes Jul 25, 2024
View reviewed changes
extensions/types/vscode-mssql.d.ts
@@ -228,7 +228,8 @@ declare module 'vscode-mssql' {
SqlDataWarehouse = 6,
SqlStretchDatabase = 7,
SqlManagedInstance = 8,
SqlOnDemand = 11
SqlOnDemand = 11,
SqlDbFabric = 12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to also update this in the vscode-mssql repo https://github.com/microsoft/vscode-mssql/blob/main/typings/vscode-mssql.d.ts#L221

Copy link
Contributor Author

@ssreerama ssreerama Jul 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created the PR: microsoft/vscode-mssql#17947

@ssreerama
Copy link
Contributor Author

Any Idea why CI/macOS check is failing? seeing some storageMainService.test.js test failures

@ssreerama
Copy link
Contributor Author

While verifying all other merged PRs have the same check failed with same test failures. Merging the PR based on the conclusion.

@ssreerama ssreerama merged commit befbaaf into main Jul 25, 2024
8 of 9 checks passed
@ssreerama ssreerama deleted the sai/sqlProjFabricSupport branch July 25, 2024 22:49
kburtram added a commit that referenced this pull request Jul 29, 2024
@kburtram @erpett
@dependabot @laurennat @ssreerama @kisantia
Port dependency bumps and accessibility fixes to rel/1.49 branch (#25793
6e6d22d 
)

* vBumping post release branch split (#25747)

* Update to latest STS (#25750)

* Bump braces from 3.0.2 to 3.0.3 in /extensions/import (#25745)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update STS to 5.0.20240718.1 (#25754)

* Bump braces from 3.0.2 to 3.0.3 in /extensions/datavirtualization (#25751)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump braces from 3.0.2 to 3.0.3 in /extensions/data-workspace (#25756)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump braces from 3.0.2 to 3.0.3 in /extensions/dacpac (#25758)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fixed column header screen reader bug (#25768)

* Revert "fixed column header screen reader bug (#25768)" (#25769)

This reverts commit ae652f7.

* Fixed column screen reader bug and ensure tests work (#25770)

* fixed column header screen reader bug

* fixed case of undefined aria label

* Bump braces from 3.0.2 to 3.0.3 in /extensions/cms (#25763)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump openssl from 0.10.60 to 0.10.66 in /cli (#25764)

Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.60 to 0.10.66.
- [Release notes](https://github.com/sfackler/rust-openssl/releases)
- [Commits](sfackler/rust-openssl@openssl-v0.10.60...openssl-v0.10.66)

---
updated-dependencies:
- dependency-name: openssl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update STS to 5.0.20240724.1 (#25774)

* Bump braces from 3.0.2 to 3.0.3 in /extensions/azurecore (#25771)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump braces from 3.0.2 to 3.0.3 in /extensions/azcli (#25775)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Adding Fabric SQL Mirrored support to the SQL Projects (#25772)

* Adding Sql fabric platform support to sqlProj extension and vBump BuildSdk version to 0.2.0-preview

* updating the display targetPlat text and updaing the buildSDK version in template

* Update extensions/sql-database-projects/src/sqldbproj.d.ts

Update text

Co-authored-by: Kim Santiago <[email protected]>

* Adding fabric engine edition

* adding missing engine edition to sqlhostType

---------

Co-authored-by: Kim Santiago <[email protected]>

* sqlProj vbump (#25781)

* Fixed text focus/ page item focus issue on forms and wizards (#25782)

* fixed column header screen reader bug

* fixed case of undefined aria label

* added text focus, and added form item focus

* Fixed screen reader not announcing table row number (#25784)

* fixed column header screen reader bug

* fixed case of undefined aria label

* added text focus, and added form item focus

* fixed row results not getting announced

* added punctuation

* Fix length bug on row aria labels for tables (#25789)

* fixed column header screen reader bug

* fixed case of undefined aria label

* added text focus, and added form item focus

* fixed row results not getting announced

* added punctuation

* Fix length check bug

* remove extra row aria call

* trying to fix nls pipeline bug (#25790)

* Bump braces from 3.0.2 to 3.0.3 in /extensions/arc (#25776)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "vBumping post release branch split (#25747)"

This reverts commit 5ae6f59.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: erpett <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: laurennat <[email protected]>
Co-authored-by: Sai Avishkar Sreerama <[email protected]>
Co-authored-by: Kim Santiago <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisantia kisantia kisantia approved these changes

@llali llali llali approved these changes

@Benjin Benjin Awaiting requested review from Benjin Benjin is a code owner

@kburtram kburtram Awaiting requested review from kburtram

@dzsquared dzsquared Awaiting requested review from dzsquared

@chlafreniere chlafreniere Awaiting requested review from chlafreniere

@alanrenmsft alanrenmsft Awaiting requested review from alanrenmsft alanrenmsft is a code owner

@Charles-Gagnon Charles-Gagnon Awaiting requested review from Charles-Gagnon Charles-Gagnon is a code owner

Assignees

@ssreerama ssreerama

Labels
Area - SQL Project
Projects
None yet
Milestone
July 2024 Release
Development

Successfully merging this pull request may close these issues.

SQL Fabric platform Support to the SQL Projects
5 participants
@ssreerama @coveralls @llali @Charles-Gagnon @kisantia