Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] Adding gulp task that adds ads metadata to exe file. (#25665) #25707

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Jun 17, 2024

The new internal official pipeline requires this gulp task. Porting it to release/1.48 allows us to fully validate the new pipeline against the release branch.

Dependent on #25706 to get PR builds against this release branch to run.

@Benjin Benjin requested a review from kburtram June 17, 2024 20:27
@coveralls
Copy link

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9554310336

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 41.759%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/book/bookTreeView.ts 1 36.91%
Totals Coverage Status
Change from base Build 9506383047: 0.0%
Covered Lines: 30828
Relevant Lines: 69082

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9573035574

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 41.757%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/book/bookTreeView.ts 1 36.91%
Totals Coverage Status
Change from base Build 9506383047: -0.002%
Covered Lines: 30827
Relevant Lines: 69082

💛 - Coveralls

@Benjin Benjin merged commit 1bccf01 into release/1.48 Jun 19, 2024
7 of 8 checks passed
@Benjin Benjin deleted the benjin/portGulpTask branch June 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants