Add null checks for undefined include/exclude patterns in search view #25336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7938152331Details
💛 - Coveralls |
kisantia
approved these changes
Feb 20, 2024
corivera
added a commit
that referenced
this pull request
Feb 20, 2024
kisantia
pushed a commit
that referenced
this pull request
Feb 20, 2024
ssreerama
added a commit
that referenced
this pull request
Feb 22, 2024
* Add null checks for undefined include/exclude patterns in search view (#25336) (#25354) * Add write permissions to PR labelling action (#25356) (#25359) * Updating STS new version (#25357) * vbump sql projects after insiders release to 1.4.2 * vbump sql projects after insiders release to 1.4.2 --------- Co-authored-by: Cory Rivera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24877
The search bar used in the notebook viewlet overrides the default search view rendering behavior, which means the include/exclude pattern objects in the base class never get created. This was causing undefined errors when trying to open the notebook find results in the editor, so the fix here was just to add some optional chaining operators. We weren't using include & exclude patterns for notebook searches, so there's no issue leaving those as undefined. I checked the console log and no errors were getting reported from passing undefined values either.