Handle empty package list during python installation #25332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corivera
requested review from
smartguest,
lucyzhang929,
kisantia and
SakshiS-harma
Pull Request Test Coverage Report for Build 7936952128Details
💛 - Coveralls |
|
I'll go ahead and merge this without waiting for sign offs, since people are out for the long weekend and it's a pretty simple change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25049
If there's an error when retrieving the list of python packages we return an empty array instead. In most places we iterate over this list, so being empty isn't an issue. In this spot we were using a
findcall though, which would return undefined when the array is empty. This change adds an undefined check before using the results of that find call.