Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update socks package to remove dependency on ip npm package #25323

Merged
merged 1 commit into from
Feb 14, 2024
Merged

update socks package to remove dependency on ip npm package #25323

merged 1 commit into from
Feb 14, 2024

Conversation

kisantia
Copy link
Contributor

Updating the socks package to resolve to version 2.7.3 that no longer has a dependency on the ip npm package, which has the vulnerability GHSA-78xj-cgh5-2h22.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7893210146

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 41.761%
Totals Coverage Status
Change from base Build 7847525911: 0.003%
Covered Lines: 30830
Relevant Lines: 69083
💛 - Coveralls

@kisantia kisantia merged commit c1b71b8 into main Feb 14, 2024
15 checks passed
@kisantia kisantia deleted the kisantia/removeIpDependency branch February 14, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@kburtram kburtram Awaiting requested review from kburtram

@corivera corivera Awaiting requested review from corivera

@cheenamalhotra cheenamalhotra Awaiting requested review from cheenamalhotra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kisantia @coveralls @Charles-Gagnon