Handle undefined source database name in restore dialog #25301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corivera
commented
Feb 6, 2024
| @@ -235,7 +235,6 @@ export class RestoreDatabaseDialog extends ObjectManagementDialogBase<Database, | |||
| // Restore from | |||
| const restoreFromDropdownOptions = this.isManagedInstance ? [localizedConstants.RestoreFromUrlText, localizedConstants.RestoreFromS3UrlText] : [localizedConstants.RestoreFromDatabaseOptionText, localizedConstants.RestoreFromBackupFileOptionText, localizedConstants.RestoreFromUrlText, localizedConstants.RestoreFromS3UrlText]; | |||
| this.restoreFrom = this.createDropdown(localizedConstants.RestoreFromText, async (newValue) => { | |||
| this.backupFilePath = this.backupURLPath = ''; | |||
There was a problem hiding this comment.
Other small fix: this line was causing the file input box to be cleared when switching modes back and forth. These cached values get used immediately below this to restore the input box value, so they don't need to be here.
Charles-Gagnon
approved these changes
Feb 6, 2024
kisantia
approved these changes
Feb 6, 2024
barbaravaldez
approved these changes
Feb 6, 2024
Pull Request Test Coverage Report for Build 7807458123
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When first switching to File mode in the Restore dialog, the loading spinner in the corner would keep running forever without any data showing up in the table. This is because an error was being thrown (from the ModelView code) due to an undefined value in the source database dropdown, and so resetting the loading state would get skipped. This change fixes that undefined string issue and also adds a try-finally block for the loading logic so it doesn't get stuck on error.