Premium SSD v2 disks in SQL VM recommendations #24556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramudaykumar
requested review from
raymondtruong,
brian-harris and
junierch
as code owners
brian-harris
reviewed
Oct 2, 2023
brian-harris
reviewed
Oct 2, 2023
extensions/sql-migration/src/dialog/skuRecommendationResults/skuRecommendationResultsDialog.ts
Outdated
Show resolved
Hide resolved
brian-harris
reviewed
Oct 2, 2023
extensions/sql-migration/src/dialog/skuRecommendationResults/skuRecommendationResultsDialog.ts
Outdated
Show resolved
Hide resolved
brian-harris
reviewed
Oct 2, 2023
deepvyas
reviewed
Oct 3, 2023
extensions/sql-migration/src/dialog/skuRecommendationResults/skuRecommendationResultsDialog.ts
Outdated
Show resolved
Hide resolved
deepvyas
reviewed
Oct 3, 2023
deepvyas
approved these changes
Oct 4, 2023
siyao-Siyang
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Premium SSD v2 disks in SQL VM recommendations * Resolving review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include Premium SSD v2 disks in SQL VM recommendations.
SQL VM recommendations (Removed Disk details to keep clean):
Configuration details to show disk details:
