Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Cancel button label to Back for inner dialogs. #24537

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

corivera
Copy link
Member

Fixes #23738

This PR changes the cancel button label for the file browser and find object dialogs we use in the basic admin space. Those are inner dialogs that get opened from another dialog, so having Cancel for those may cause confusion as to whether it will close the entire dialog or just the inner one. Using Back instead seems more appropriate.

@corivera corivera merged commit 94cdaf9 into main Sep 29, 2023
@corivera corivera deleted the corivera/userManagement branch September 29, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear whether "cancel" in "Add Objects" dialog cancels the entire operation or just "Add Objects"
2 participants