Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of the issues found in the bug bash #24348

Merged
merged 5 commits into from
Sep 9, 2023
Merged

Fix some of the issues found in the bug bash #24348

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf4badf
fix cancel behavior
barbaravaldez Sep 8, 2023
dba6350
disable fullTextUpgradeOption if is empty
barbaravaldez Sep 8, 2023
6376d01
Merge branch 'main' into bavaldez/bugbash
barbaravaldez Sep 9, 2023
b8c4ff1
pr comments
barbaravaldez Sep 9, 2023
e3f9ea3
pr comments
barbaravaldez Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions extensions/mssql/src/objectManagement/ui/serverPropertiesDialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,8 +597,10 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
}, dataLocationInputboxProps);
const dataLocationButton = this.createBrowseButton(async () => {
const newPath = await this.selectFolder(this.objectInfo.dataLocation);
this.dataLocationInput.value = newPath;
this.objectInfo.dataLocation = newPath;
if (newPath) {
this.dataLocationInput.value = newPath;
this.objectInfo.dataLocation = newPath;
}
if (this.objectInfo.dataLocation !== this.originalObjectInfo.dataLocation) {
this.shouldRestartServer = true;
}
Expand All @@ -613,8 +615,10 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
}, logLocationInputboxProps);
const logLocationButton = this.createBrowseButton(async () => {
const newPath = await this.selectFolder(this.objectInfo.logLocation);
this.logLocationInput.value = newPath;
this.objectInfo.logLocation = newPath;
if (newPath) {
this.logLocationInput.value = newPath;
this.objectInfo.logLocation = newPath;
}
if (this.objectInfo.logLocation !== this.originalObjectInfo.logLocation) {
this.shouldRestartServer = true;
}
Expand All @@ -626,8 +630,10 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
}, backupLocationInputboxProps);
const backupLocationButton = this.createBrowseButton(async () => {
const newPath = await this.selectFolder(this.objectInfo.backupLocation);
this.backupLocationInput.value = newPath;
this.objectInfo.backupLocation = newPath;
if (newPath) {
this.backupLocationInput.value = newPath;
this.objectInfo.backupLocation = newPath;
}
}, isEnabled);
const backupLocationInputContainer = this.createLabelInputContainer(localizedConstants.backupLocationText, [this.backupLocationInput, backupLocationButton])

Expand Down Expand Up @@ -706,7 +712,7 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S

this.fullTextUpgradeOptionDropdown = this.createDropdown(localizedConstants.fullTextUpgradeOptionLabel, async (newValue) => {
this.objectInfo.fullTextUpgradeOption = newValue;
}, this.viewInfo.fullTextUpgradeOptions, this.objectInfo.fullTextUpgradeOption);
}, this.viewInfo.fullTextUpgradeOptions, this.objectInfo.fullTextUpgradeOption, !!this.objectInfo.fullTextUpgradeOption);
const fullTextUpgradeOptionContainer = this.createLabelInputContainer(localizedConstants.fullTextUpgradeOptionLabel, this.fullTextUpgradeOptionDropdown);

this.maxTextReplicationSizeInput = this.createInputBox(async (newValue) => {
Expand Down