Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix F11 key binding #24323

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Fix F11 key binding #24323

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b34b0a1
Fix F11 key binding to non-debug mode
SakshiS-harma Sep 6, 2023
361828c
Disable F11 keybinding completely to toggle between full screen
SakshiS-harma Sep 6, 2023
e5b0c9f
Fix compile error
SakshiS-harma Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/vs/workbench/contrib/debug/browser/debugCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,8 @@ KeybindingsRegistry.registerCommandAndKeybindingRule({
});

// Windows browsers use F11 for full screen, thus use alt+F11 as the default shortcut
const STEP_INTO_KEYBINDING = (isWeb && isWindows) ? (KeyMod.Alt | KeyCode.F11) : KeyCode.F11;
// {{SQL CARBON EDIT}} - Disable F11 binding to use it as shortcut for full screen in ADS
/*const STEP_INTO_KEYBINDING = (isWeb && isWindows) ? (KeyMod.Alt | KeyCode.F11) : KeyCode.F11;

KeybindingsRegistry.registerCommandAndKeybindingRule({
id: STEP_INTO_ID,
Expand All @@ -503,7 +504,7 @@ KeybindingsRegistry.registerCommandAndKeybindingRule({
await getThreadAndRun(accessor, context, (thread: IThread) => thread.stepIn());
}
}
});
});*/

KeybindingsRegistry.registerCommandAndKeybindingRule({
id: STEP_OUT_ID,
Expand Down Expand Up @@ -533,7 +534,7 @@ KeybindingsRegistry.registerCommandAndKeybindingRule({

KeybindingsRegistry.registerCommandAndKeybindingRule({
id: STEP_INTO_TARGET_ID,
primary: STEP_INTO_KEYBINDING | KeyMod.CtrlCmd,
primary: KeyMod.CtrlCmd, // {{SQL CARBON EDIT}} - Remove STEP_INTO_KEYBINDING
when: ContextKeyExpr.and(CONTEXT_STEP_INTO_TARGETS_SUPPORTED, CONTEXT_IN_DEBUG_MODE, CONTEXT_DEBUG_STATE.isEqualTo('stopped')),
weight: KeybindingWeight.WorkbenchContrib,
handler: async (accessor: ServicesAccessor, _: string, context: CallStackContext | unknown) => {
Expand Down