Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling FILEGROUPS tab experience to the database properties #24226

Merged
merged 123 commits into from
Aug 31, 2023
Merged
Show file tree
Hide file tree
Changes from 121 commits
Commits
Show all changes
123 commits
Select commit Hold shift + click to select a range
8c090dc
initial changes for loadin dsc table with real values from smo
ssreerama Jul 14, 2023
064d069
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Jul 14, 2023
48ebe40
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Jul 17, 2023
d599463
Displaying diff columns for DSC for diff sql server
ssreerama Jul 17, 2023
874c8e2
checkbox maiants the selection
ssreerama Jul 19, 2023
5763790
elevate option fails to load correct value when set to when_supported…
ssreerama Jul 20, 2023
cd2ca3f
all working till maxdop, todo pause option, save
ssreerama Jul 20, 2023
bd7b6fe
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Jul 20, 2023
0cedabf
commented MAXDOP changes, as it is causing issues
ssreerama Jul 21, 2023
4473be9
primary,sec,checkbox working as expected, TODO:MaxDop etc options,sav…
ssreerama Jul 24, 2023
8aca6ad
Undo MAXDOP commented code
ssreerama Jul 24, 2023
63d140b
refactored with service data
ssreerama Jul 24, 2023
c66f20d
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Jul 24, 2023
f623d65
column header width adjustments
ssreerama Jul 25, 2023
a675e89
Maxdop and pause resume options completed, apply button is failing now
ssreerama Jul 26, 2023
9454492
Removed option names from loc and using Id instead as names may chan…
ssreerama Jul 26, 2023
751138a
Apply button fixed
ssreerama Jul 26, 2023
c1272b2
refactored to reduce table reload
ssreerama Jul 26, 2023
48bd3f7
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Jul 26, 2023
bfe0b31
Ledger digest completed
ssreerama Jul 27, 2023
89af409
refactor done: maxdop secondary shows wrong data from pause_resume
ssreerama Jul 27, 2023
47b4103
refactor more: all working but table focus disturbs on update table
ssreerama Jul 27, 2023
fb8104a
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Jul 28, 2023
e5e26f4
adds conditions for unsupported dsc to <2016 server
ssreerama Jul 28, 2023
a770600
maxdop secondary checkbox fix
ssreerama Jul 28, 2023
eaeafbc
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Jul 28, 2023
be08abf
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Jul 31, 2023
d79fdf6
rows still loses focus after value change due to update table row data
ssreerama Jul 31, 2023
39c3d94
Fixed updating secondary dropdown value
ssreerama Jul 31, 2023
6be89da
reusing the private method and removed the duplicated codes
ssreerama Aug 1, 2023
6fe0404
initial commit - fullText and owner need revision
ssreerama Aug 1, 2023
fef8ed9
Enter key in input type allows the change to update the table data, r…
ssreerama Aug 2, 2023
4adbcdb
Setting focus to the current row
ssreerama Aug 2, 2023
87c4902
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 2, 2023
95ffa05
loading data, need stylings-increase col length, etc
ssreerama Aug 3, 2023
2bf4391
using the existed setTableData method
ssreerama Aug 3, 2023
4f5f6ff
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 3, 2023
282625a
Adding new file dialog
ssreerama Aug 4, 2023
607a739
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Aug 4, 2023
cd464fd
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 7, 2023
6c241ed
creating addFile, but not displaying in table, issue with appendData
ssreerama Aug 7, 2023
872f6d4
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Aug 8, 2023
a064ad1
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 8, 2023
de00241
Adding row to the table, options are getting from STS
ssreerama Aug 8, 2023
90adef5
all working except InPercent value
ssreerama Aug 9, 2023
9c6076b
code review comment updates
ssreerama Aug 9, 2023
0f344c1
Input type checkbox update table additional validation
ssreerama Aug 9, 2023
d9d678f
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 9, 2023
fcb1131
all except path
ssreerama Aug 9, 2023
94ea2ff
fixing the input type focus and reverting the enterKeyPress logic
ssreerama Aug 9, 2023
da496ff
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 9, 2023
5cf004a
browse path is created, need stylings,refactor,filestream selection a…
ssreerama Aug 9, 2023
778a33e
fixing the flickering issue with data refresh
ssreerama Aug 10, 2023
8076153
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Aug 10, 2023
c93403b
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 10, 2023
60a3b1f
new file options toggle and grid display string updates
ssreerama Aug 11, 2023
fc706ee
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Aug 11, 2023
b742750
moving code inline and using actual component
ssreerama Aug 11, 2023
2021a99
cleanup
ssreerama Aug 11, 2023
e58dcfe
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 11, 2023
b1798f0
Add file saving is done, except one styling issue with autogrowth sec…
ssreerama Aug 11, 2023
5582058
add,remove working, need to edit file
ssreerama Aug 14, 2023
1c04976
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Aug 14, 2023
56ed3fb
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 14, 2023
832d348
add, edit, remove - all working, need css fixes and -1 fix
ssreerama Aug 15, 2023
4cfade3
addressing code review comments
ssreerama Aug 15, 2023
151e2ee
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Aug 15, 2023
fe6334b
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 15, 2023
58a5623
adding local changes adn fixing for edit file
ssreerama Aug 15, 2023
2cdb88a
adjusting css
ssreerama Aug 15, 2023
2ddd360
Merge branch 'main' into sai/dscTab_dbProperties
ssreerama Aug 15, 2023
9de9192
addressing code review comment for using loc var instead of duplicate…
ssreerama Aug 15, 2023
c27884b
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 16, 2023
5d02ad8
all fixed, need testing and refactor
ssreerama Aug 16, 2023
2253cda
vBump STS and fixing required field causing the apply button not ena…
ssreerama Aug 16, 2023
dec3061
Merge branch 'sai/dscTab_dbProperties' into sai/filesTab
ssreerama Aug 16, 2023
6ea33b1
fixing autogrowth radio buttons change updates
ssreerama Aug 16, 2023
b2720eb
all working except some css
ssreerama Aug 18, 2023
c9e3ab5
disabled size for filestream
ssreerama Aug 18, 2023
1936280
fixing filegroups and filetypes scnearios, added filename validation …
ssreerama Aug 18, 2023
106f63f
added max and min values to the inputs
ssreerama Aug 21, 2023
5575049
merge conflicts resolved
ssreerama Aug 21, 2023
a9f0560
editing filename validation completed, all done exccept CSS
ssreerama Aug 21, 2023
9e957de
all fixed except scroll bar
ssreerama Aug 21, 2023
78b0d28
edit db file header, filename enable issue fix
ssreerama Aug 21, 2023
3af7522
Merge branch 'main' into sai/filesTab
ssreerama Aug 21, 2023
6dc42f6
PR comment supporting updates for STS
ssreerama Aug 21, 2023
7baaba1
initial commit
ssreerama Aug 22, 2023
d42d2f2
Merge branch 'main' into sai/filesTab
ssreerama Aug 22, 2023
265b566
min updates
ssreerama Aug 22, 2023
2dfbe89
Merge branch 'sai/filesTab' into sai/fileGroupsTab
ssreerama Aug 22, 2023
dbfa6dd
loading data into table.. adding rows
ssreerama Aug 23, 2023
f9476d4
modfying addButtonsForTable method and reusing it for edit button
ssreerama Aug 23, 2023
e545f6b
Merge branch 'sai/filesTab' into sai/fileGroupsTab
ssreerama Aug 23, 2023
489c9b9
add empty row/remove done, edit name and other columns required and s…
ssreerama Aug 23, 2023
1bed23b
All working except new name validation
ssreerama Aug 23, 2023
b9fd859
adding validation
ssreerama Aug 23, 2023
01ed27a
code review comment updates
ssreerama Aug 24, 2023
b4ef28f
Dialogbase addbuttons to table refactored
ssreerama Aug 24, 2023
27045d7
Merge branch 'sai/filesTab' into sai/fileGroupsTab
ssreerama Aug 24, 2023
570cc4f
more typo fixes
ssreerama Aug 24, 2023
3689c02
Merge branch 'main' into sai/filesTab
ssreerama Aug 24, 2023
98b895e
Merge branch 'sai/filesTab' into sai/fileGroupsTab
ssreerama Aug 24, 2023
6eac477
all working except 'Remove' revist logic and delete correct row
ssreerama Aug 25, 2023
b9d384e
removing fulltext index prop
ssreerama Aug 25, 2023
b4d68f4
Merge branch 'sai/filesTab' into sai/fileGroupsTab
ssreerama Aug 25, 2023
9517adc
adding defualt conditions to the columns checkboxes
ssreerama Aug 25, 2023
ee59ec8
service fix
ssreerama Aug 25, 2023
28f8489
Merge branch 'sai/filesTab' into sai/fileGroupsTab
ssreerama Aug 25, 2023
1dc7048
using path.join instead of hardcoded separators
ssreerama Aug 26, 2023
10530df
Merge branch 'sai/filesTab' into sai/fileGroupsTab
ssreerama Aug 26, 2023
fccf1f9
updating files is updating filegroups tabs, removing fg to file updat…
ssreerama Aug 27, 2023
10a3270
fixed toggle remove button for tab;es
ssreerama Aug 27, 2023
378b472
filegroup refactor
ssreerama Aug 28, 2023
fa0d074
Merge branch 'main' into sai/filesTab
ssreerama Aug 28, 2023
e1c47e8
Merge branch 'sai/filesTab' into sai/fileGroupsTab
ssreerama Aug 28, 2023
85e0ac0
update filegroups and files on new fg name
ssreerama Aug 28, 2023
431f112
final commit changes
ssreerama Aug 29, 2023
9932357
Merge branch 'sai/filesTab' into sai/fileGroupsTab
ssreerama Aug 29, 2023
941bc7e
Merge branch 'main' into sai/fileGroupsTab
ssreerama Aug 29, 2023
2754e9d
code review updates
ssreerama Aug 30, 2023
78d568e
vBump STS to 4.9.0.26
ssreerama Aug 30, 2023
ad60fc0
Merge branch 'main' into sai/fileGroupsTab
ssreerama Aug 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/mssql/src/objectManagement/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export const DatabaseOptionsPropertiesDocUrl = 'https://learn.microsoft.com/sql/
export const DropDatabaseDocUrl = 'https://learn.microsoft.com/sql/t-sql/statements/drop-database-transact-sql';
export const DatabaseScopedConfigurationPropertiesDocUrl = 'https://learn.microsoft.com/sql/t-sql/statements/alter-database-scoped-configuration-transact-sql'
export const DatabaseFilesPropertiesDocUrl = 'https://learn.microsoft.com/sql/relational-databases/databases/database-properties-files-page'
export const DatabaseFileGroupsPropertiesDocUrl = 'https://learn.microsoft.com/sql/relational-databases/databases/database-properties-filegroups-page'

export const enum TelemetryActions {
CreateObject = 'CreateObject',
Expand Down
16 changes: 16 additions & 0 deletions extensions/mssql/src/objectManagement/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,7 @@ export interface Database extends ObjectManagement.SqlObject {
databaseScopedConfigurations: DatabaseScopedConfigurationsInfo[];
isFilesTabSupported?: boolean;
files?: DatabaseFile[];
filegroups?: FileGroup[];
}

export interface DatabaseViewInfo extends ObjectManagement.ObjectViewInfo<Database> {
Expand Down Expand Up @@ -575,6 +576,12 @@ export const enum FileGrowthType {
None = 99
}

export const enum FileGroupType {
RowsFileGroup = 0,
FileStreamDataFileGroup = 2,
MemoryOptimizedDataFileGroup = 3
}

export interface DatabaseFile {
id: number;
name: string;
Expand All @@ -588,3 +595,12 @@ export interface DatabaseFile {
autoFileGrowthType: FileGrowthType;
maxSizeLimitInMb: number
}

export interface FileGroup {
id?: number;
name: string;
type: FileGroupType;
isReadOnly: boolean;
isDefault: boolean;
autogrowAllFiles: boolean;
}
12 changes: 12 additions & 0 deletions extensions/mssql/src/objectManagement/localizedConstants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ export const GeneralSectionHeader = localize('objectManagement.generalSectionHea
export const AdvancedSectionHeader = localize('objectManagement.advancedSectionHeader', "Advanced");
export const OptionsSectionHeader = localize('objectManagement.optionsSectionHeader', "Options");
export const FilesSectionHeader = localize('objectManagement.optionsSectionHeader', "Files");
export const FileGroupsSectionHeader = localize('objectManagement.filegroupsSectionHeader', "Filegroups");
export const PasswordText = localize('objectManagement.passwordLabel', "Password");
export const ConfirmPasswordText = localize('objectManagement.confirmPasswordLabel', "Confirm password");
export const EnabledText = localize('objectManagement.enabledLabel', "Enabled");
Expand Down Expand Up @@ -374,6 +375,17 @@ export const FilegrowthLimitError = localize('objectManagement.databasePropertie
export const RowsDataFileType = localize('objectManagement.databaseProperties.rowsDataFileType', "ROWS Data");
export const LogFiletype = localize('objectManagement.databaseProperties.logfiletype', "LOG");
export const FilestreamFileType = localize('objectManagement.databaseProperties.filestreamFileType', "FILESTREAM Data");
export const RowsFileGroupsSectionText = localize('objectManagement.databaseProperties.rowsFileGroupsSectionText', "Rows");
export const FileStreamFileGroupsSectionText = localize('objectManagement.databaseProperties.fileStreamFileGroupsSectionText', "FileStream");
export const MemoryOptimizedFileGroupsSectionText = localize('objectManagement.databaseProperties.memoryOptimizedFileGroupsSectionText', "Memory Optimized Data");
export const FilesText = localize('objectManagement.databaseProperties.filesText', "Files");
export const ReadOnlyText = localize('objectManagement.databaseProperties.readOnlyText', "Read-Only");
export const DefaultText = localize('objectManagement.databaseProperties.defaultText', "Default");
export const AutogrowAllFilesText = localize('objectManagement.databaseProperties.autogrowAllFilesText', "Autogrow All Files");
export const FilestreamFilesText = localize('objectManagement.databaseProperties.filestreamFilesText', "Filestream Files");
export const AddFilegroupText = localize('objectManagement.databaseProperties.addFilegroupButtonText', "Add Filegroup");
export const FilegroupExistsError = (name: string) => localize('objectManagement.databaseProperties.FilegroupExistsError', "File group '{0}' could not be added to the collection, because it already exists.", name);
export const EmptyFilegroupNameError = localize('objectManagement.databaseProperties.emptyFilegroupNameError', "Cannot use empty object names for filegroups.");

// Util functions
export function getNodeTypeDisplayName(type: string, inTitle: boolean = false): string {
Expand Down
Loading