Enabling Database scoped configurations tab to DB Properties #23890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssreerama
changed the title
…e in future like in doc
ssreerama
requested review from
Charles-Gagnon,
corivera,
barbaravaldez and
chlafreniere
and removed request for
corivera,
barbaravaldez,
chlafreniere and
Charles-Gagnon
corivera
reviewed
Aug 14, 2023
corivera
reviewed
Aug 14, 2023
corivera
reviewed
Aug 14, 2023
corivera
reviewed
Aug 15, 2023
corivera
reviewed
Aug 15, 2023
Charles-Gagnon
approved these changes
Aug 15, 2023
|
STS PR is checked in already, once the new release is available will do a vbump here or in separate PR. Thanks :) |
…d line of code to get the rowinfo
corivera
approved these changes
Aug 15, 2023
…le for other options on main branch
|
|
corivera
pushed a commit
that referenced
this pull request
Aug 17, 2023
* initial changes for loadin dsc table with real values from smo * Displaying diff columns for DSC for diff sql server * checkbox maiants the selection * elevate option fails to load correct value when set to when_supported option * all working till maxdop, todo pause option, save * commented MAXDOP changes, as it is causing issues * primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests * Undo MAXDOP commented code * refactored with service data * column header width adjustments * Maxdop and pause resume options completed, apply button is failing now * Removed option names from loc and using Id instead as names may change in future like in doc * Apply button fixed * refactored to reduce table reload * Ledger digest completed * refactor done: maxdop secondary shows wrong data from pause_resume * refactor more: all working but table focus disturbs on update table * adds conditions for unsupported dsc to <2016 server * maxdop secondary checkbox fix * rows still loses focus after value change due to update table row data * Fixed updating secondary dropdown value * reusing the private method and removed the duplicated codes * Enter key in input type allows the change to update the table data, reduces the live update issues * Setting focus to the current row * using the existed setTableData method * code review comment updates * Input type checkbox update table additional validation * fixing the input type focus and reverting the enterKeyPress logic * fixing the flickering issue with data refresh * moving code inline and using actual component * cleanup * addressing code review comments * addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo * vBump STS and fixing required field causing the apply button not enable for other options on main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to view/modify database scoped configurations options of a database in a separate DSC tab.
a. All properties opens dropdown section on selection with ON/OFF options.
b. Elevate properties opens OFF/When_supported/Fail_supported options.
c. MAXDOP/ Pause_resumable... properties opens numeric input types etc
d. LEDGER_DIGEST options accepts azure blob endpoint path as value, also can select OFF from the dropdown