Enable no-unsafe-assignments for MSSQL #23407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
AkshayMata,
raymondtruong,
brian-harris,
junierch,
Benjin,
kisantia,
VasuBhog,
lucyzhang929,
chlafreniere,
MaddyDev,
llali,
aasimkhan30,
swells and
candiceye
as code owners
alanrenmsft
reviewed
Jun 16, 2023
extensions/mssql/src/utils.ts
Outdated
| @@ -223,7 +223,7 @@ export function getErrorMessage(error: Error | any, removeHeader: boolean = fals | |||
| if (error instanceof Error) { | |||
| errorMessage = error.message; | |||
| } else if (error.responseText) { | |||
| errorMessage = error.responseText; | |||
| errorMessage = error.responseText.toString() as string; | |||
There was a problem hiding this comment.
why adding the .toString() here?
There was a problem hiding this comment.
Because error.responseText could be anything. It should always be a string (and was previously assumed to be so) so technically could get rid of it I guess. (yet again I really wish TS had better built in error support...)
alanrenmsft
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-unsafe-assignment.md
anyis dangerous to use in a lot of situations, so wherever we can be explicit about not using it the better. I'm enabling this for the MSSQL extension, and then moving it to the extension-level eslintrc so that other extensions can easily enable it later if needed (and new extensions get it automatically).Smallish number of fixes, none of them a concern that I saw.