Update redirect-uri to localhost #20692
Conversation
extensions/azurecore/src/account-provider/auths/azureAuthCodeGrant.ts
Outdated
Show resolved
Hide resolved
| @@ -93,7 +93,7 @@ const publicAzureSettings: ProviderSettings = { | |||
| endpoint: 'https://analysis.windows.net/powerbi/api', | |||
| azureResourceId: AzureResource.PowerBi | |||
| }, | |||
| redirectUri: 'https://vscode-redirect.azurewebsites.net/', | |||
| redirectUri: 'http://localhost', | |||
There was a problem hiding this comment.
Per https://learn.microsoft.com/en-us/azure/active-directory/develop/reply-url#localhost-exceptions we should be using 127.0.0.1 instead of localhost - although they also mention you have to do some wonky configuration to do that which seems odd...
There was a problem hiding this comment.
I saw that too, but I think we'll just use localhost for now, that's also what SSMS is doing
| @@ -20,7 +20,7 @@ import { MicrosoftAuthenticationSession } from './microsoft-authentication'; | |||
|
|
|||
| const localize = nls.loadMessageBundle(); | |||
|
|
|||
| const redirectUrl = 'https://vscode-redirect.azurewebsites.net/'; | |||
| const redirectUrl = 'http://localhost/redirect'; | |||
There was a problem hiding this comment.
Is this even used anywhere? Since we use our own custom account handler I didn't think there was anywhere in the app users could actually sign in to their Microsoft account.
There was a problem hiding this comment.
I don't think this is used anywhere.
There was a problem hiding this comment.
This should have a SQL CARBON EDIT. But if it's not used anywhere I would suggest just reverting it - the fewer changes we make to VS Code stuff the easier merges are.
Updating our redirect-uri from an external website (https://vscode-redirect.azurewebsites.net/) to http://localhost/redirect. This unblocks proxy users from adding their accounts to ADS.
Fixes #17356