Skip to content

Commit

Permalink
removing unused ChartClickEvent type until data selection eventing is…
Browse files Browse the repository at this point in the history
… implemented
  • Loading branch information
Benjin committed Sep 13, 2023
1 parent 95f2605 commit 91b0cb0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions src/sql/azdata.proposed.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2082,11 +2082,9 @@ declare module 'azdata' {
}

export interface ChartComponent<TChartType extends ChartType, TData extends ChartData<TChartType>, TOptions extends ChartOptions<TChartType>> extends Component, ChartComponentProperties<TChartType, TData, TOptions> {
onDidClick: vscode.Event<ChartClickEvent>;
onDidClick: vscode.Event<any>;
}

export type ChartClickEvent = { label: string };

export interface ChartComponentProperties<TChartType extends ChartType, TData extends ChartData<TChartType>, TOptions extends ChartOptions<TChartType>> extends ComponentProperties {
/**
* Type of chart to build. Must match the ChartType parameter used to construct the chart.
Expand Down
4 changes: 2 additions & 2 deletions src/sql/workbench/api/common/extHostModelView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2285,7 +2285,7 @@ class ChartComponentWrapper<TChartType extends azdata.ChartType, TData extends a
super(proxy, handle, ModelComponentTypes.Chart, id, logService);
this.properties = {};

this._emitterMap.set(ComponentEventType.onDidClick, new Emitter<azdata.ChartClickEvent>());
this._emitterMap.set(ComponentEventType.onDidClick, new Emitter<any>());
}

public set chartType(v: TChartType) {
Expand All @@ -2304,7 +2304,7 @@ class ChartComponentWrapper<TChartType extends azdata.ChartType, TData extends a
return this.properties['data'];
}

public get onDidClick(): vscode.Event<azdata.ChartClickEvent> {
public get onDidClick(): vscode.Event<any> {
let emitter = this._emitterMap.get(ComponentEventType.onDidClick);
return emitter && emitter.event;
}
Expand Down

0 comments on commit 91b0cb0

Please sign in to comment.