Merge branch 'main' into sai/fg_Declarative

microsoft · Sep 13, 2023 · 7a1d031 · 7a1d031
2 parents 8668e66 + 08ded51
commit 7a1d031
Show file tree

Hide file tree

Showing 48 changed files with 147 additions and 124 deletions.
diff --git a/.github/respond-to-issue-based-on-label.yml b/.github/respond-to-issue-based-on-label.yml
@@ -23,7 +23,7 @@ Needs Logs:
 # actions for Needs Logs - Azure label
 Needs Logs - Azure:
   comment: |
-    We need more info to debug your Azure Active Directory issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
+    We need more info to debug your Microsoft Entra ID issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
 
     - In the settings menu, find the setting titled `Azure: Logging Level` and select the `Verbose` option
     - Restart Azure Data Studio

diff --git a/extensions/azurecore/src/account-provider/auths/azureAuth.ts b/extensions/azurecore/src/account-provider/auths/azureAuth.ts
@@ -624,7 +624,7 @@ export interface TokenClaims { // https://docs.microsoft.com/en-us/azure/active-
 	aud: string;
 	/**
 	 * Identifies the issuer, or "authorization server" that constructs and
-	 * returns the token. It also identifies the Azure AD tenant for which
+	 * returns the token. It also identifies the Microsoft Entra tenant for which
 	 * the user was authenticated. If the token was issued by the v2.0 endpoint,
 	 * the URI will end in /v2.0. The GUID that indicates that the user is a consumer
 	 * user from a Microsoft account is 9188040d-6c67-4c5b-b112-36a304b66dad.
@@ -642,7 +642,7 @@ export interface TokenClaims { // https://docs.microsoft.com/en-us/azure/active-
 	 * account not in the same tenant as the issuer - guests, for instance.
 	 * If the claim isn't present, it means that the value of iss can be used instead.
 	 * For personal accounts being used in an organizational context (for instance,
-	 * a personal account invited to an Azure AD tenant), the idp claim may be
+	 * a personal account invited to a Microsoft Entra tenant), the idp claim may be
 	 * 'live.com' or an STS URI containing the Microsoft account tenant
 	 * 9188040d-6c67-4c5b-b112-36a304b66dad.
 	 */
@@ -675,7 +675,7 @@ export interface TokenClaims { // https://docs.microsoft.com/en-us/azure/active-
 	 */
 	at_hash: string;
 	/**
-	 * An internal claim used by Azure AD to record data for token reuse. Should be ignored.
+	 * An internal claim used by Microsoft Entra ID to record data for token reuse. Should be ignored.
 	 */
 	aio: string;
 	/**

diff --git a/extensions/azurecore/src/azurecore.d.ts b/extensions/azurecore/src/azurecore.d.ts
@@ -172,7 +172,7 @@ declare module 'azurecore' {
 	}
 
 	/**
-	 * Represents a resource exposed by an Azure Active Directory
+	 * Represents a resource exposed by a Microsoft Entra identity
 	 */
 	export interface Resource {
 		/**
@@ -197,7 +197,7 @@ declare module 'azurecore' {
 	}
 
 	/**
-	 * Represents a tenant (an Azure Active Directory instance) to which a user has access
+	 * Represents a Microsoft Entra tenant to which a user has access
 	 */
 	export interface Tenant {
 		/**

diff --git a/extensions/azuremonitor/package.json b/extensions/azuremonitor/package.json
@@ -209,7 +209,7 @@
     "update-grammar": "node ../../build/npm/update-grammar.js Microsoft/vscode-azuremonitor ./syntaxes/azuremonitor.tmLanguage"
   },
   "dependencies": {
-    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.7",
+    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.8",
     "figures": "^2.0.0",
     "find-remove": "1.2.1",
     "@microsoft/ads-service-downloader": "^1.2.1",

diff --git a/extensions/azuremonitor/package.nls.json b/extensions/azuremonitor/package.nls.json
@@ -27,7 +27,7 @@
 	"azuremonitor.connectionOptions.databaseName.description": "The name of the initial catalog or database in the data source",
 	"azuremonitor.connectionProperties.authType.displayName": "Authentication type",
 	"azuremonitor.connectionProperties.authType.description": "Specifies the method of authenticating with Azure Monitor",
-	"azuremonitor.connectionProperties.authType.categoryValues.azureMFA": "Azure Active Directory - Universal with MFA support",
+	"azuremonitor.connectionProperties.authType.categoryValues.azureMFA": "Microsoft Entra ID - Universal with MFA support",
 	"azuremonitor.connectionProperties.groupName.source": "Source",
 	"azuremonitor.connectionProperties.groupName.security": "Security"
 }
diff --git a/extensions/azuremonitor/yarn.lock b/extensions/azuremonitor/yarn.lock
@@ -75,9 +75,9 @@ [email protected]:
   resolved "https://registry.yarnpkg.com/concat-map/-/concat-map-0.0.1.tgz#d8a96bd77fd68df7793a73036a3ba0d5405d477b"
   integrity sha1-2Klr13/Wjfd5OnMDajug1UBdR3s=
 
-"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.7":
-  version "1.3.7"
-  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/0f07d03394eeebc2924971746470ac8224348fa4"
+"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.8":
+  version "1.3.8"
+  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/828b7a5e5c1c077a0f6eb7f6acecd191fbaae13d"
   dependencies:
     vscode-languageclient "5.2.1"
 

diff --git a/extensions/cms/package.nls.json b/extensions/cms/package.nls.json
@@ -53,7 +53,7 @@
 	"cms.connectionOptions.authType.description": "Specifies the method of authenticating with SQL Server",
 	"cms.connectionOptions.authType.categoryValues.sqlLogin": "SQL Login",
 	"cms.connectionOptions.authType.categoryValues.integrated": "Windows Authentication",
-	"cms.connectionOptions.authType.categoryValues.azureMFA": "Azure Active Directory - Universal with MFA support",
+	"cms.connectionOptions.authType.categoryValues.azureMFA": "Microsoft Entra ID - Universal with MFA support",
 	"cms.connectionOptions.userName.displayName": "User name",
 	"cms.connectionOptions.userName.description": "Indicates the user ID to be used when connecting to the data source",
 	"cms.connectionOptions.password.displayName": "Password",

diff --git a/extensions/datavirtualization/package.json b/extensions/datavirtualization/package.json
@@ -107,7 +107,7 @@
   "dependencies": {
     "@microsoft/ads-extension-telemetry": "^3.0.1",
     "@microsoft/ads-service-downloader": "^1.2.1",
-    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.7",
+    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.8",
     "vscode-nls": "^5.2.0"
   },
   "devDependencies": {

diff --git a/extensions/datavirtualization/yarn.lock b/extensions/datavirtualization/yarn.lock
@@ -497,9 +497,9 @@ [email protected]:
   resolved "https://registry.yarnpkg.com/crypt/-/crypt-0.0.2.tgz#88d7ff7ec0dfb86f713dc87bbb42d044d3e6c41b"
   integrity sha512-mCxBlsHFYh9C+HVpiEacem8FEBnMXgU9gy4zmNC+SXAZNB/1idgp/aulFJ4FgCi7GPEVbfyng092GqL2k2rmow==
 
-"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.7":
-  version "1.3.7"
-  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/0f07d03394eeebc2924971746470ac8224348fa4"
+"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.8":
+  version "1.3.8"
+  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/828b7a5e5c1c077a0f6eb7f6acecd191fbaae13d"
   dependencies:
     vscode-languageclient "5.2.1"
 

diff --git a/extensions/import/package.json b/extensions/import/package.json
@@ -77,7 +77,7 @@
     }
   },
   "dependencies": {
-    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.7",
+    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.8",
     "htmlparser2": "^3.10.1",
     "@microsoft/ads-service-downloader": "^1.2.1",
     "@microsoft/ads-extension-telemetry": "^3.0.1",

diff --git a/extensions/import/yarn.lock b/extensions/import/yarn.lock
@@ -572,9 +572,9 @@ crypt@~0.0.1:
   resolved "https://registry.yarnpkg.com/crypt/-/crypt-0.0.2.tgz#88d7ff7ec0dfb86f713dc87bbb42d044d3e6c41b"
   integrity sha1-iNf/fsDfuG9xPch7u0LQRNPmxBs=
 
-"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.7":
-  version "1.3.7"
-  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/0f07d03394eeebc2924971746470ac8224348fa4"
+"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.8":
+  version "1.3.8"
+  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/828b7a5e5c1c077a0f6eb7f6acecd191fbaae13d"
   dependencies:
     vscode-languageclient "5.2.1"
 

diff --git a/extensions/kusto/package.json b/extensions/kusto/package.json
@@ -427,7 +427,7 @@
     }
   },
   "dependencies": {
-    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.7",
+    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.8",
     "figures": "^2.0.0",
     "find-remove": "1.2.1",
     "@microsoft/ads-service-downloader": "^1.2.1",

diff --git a/extensions/kusto/package.nls.json b/extensions/kusto/package.nls.json
@@ -26,7 +26,7 @@
 	"kusto.connectionOptions.databaseName.description": "The name of the initial catalog or database in the data source",
 	"kusto.connectionOptions.authType.displayName": "Authentication type",
 	"kusto.connectionOptions.authType.description": "Specifies the method of authenticating with Kusto Server",
-	"kusto.connectionOptions.authType.categoryValues.azureMFA": "Azure Active Directory - Universal with MFA support",
+	"kusto.connectionOptions.authType.categoryValues.azureMFA": "Microsoft Entra ID - Universal with MFA support",
 	"kusto.connectionOptions.authType.categoryValues.none": "No Authentication",
 	"kusto.connectionOptions.authType.categoryValues.sqlLogin": "User Authentication",
 	"kusto.connectionOptions.userName.displayName": "User name",

diff --git a/extensions/kusto/yarn.lock b/extensions/kusto/yarn.lock
@@ -124,9 +124,9 @@ [email protected]:
   resolved "https://registry.yarnpkg.com/concat-map/-/concat-map-0.0.1.tgz#d8a96bd77fd68df7793a73036a3ba0d5405d477b"
   integrity sha1-2Klr13/Wjfd5OnMDajug1UBdR3s=
 
-"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.7":
-  version "1.3.7"
-  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/0f07d03394eeebc2924971746470ac8224348fa4"
+"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.8":
+  version "1.3.8"
+  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/828b7a5e5c1c077a0f6eb7f6acecd191fbaae13d"
   dependencies:
     vscode-languageclient "5.2.1"
 

diff --git a/extensions/mssql/config.json b/extensions/mssql/config.json
@@ -1,6 +1,6 @@
 {
 	"downloadUrl": "https://github.com/Microsoft/sqltoolsservice/releases/download/{#version#}/microsoft.sqltools.servicelayer-{#fileName#}",
-	"version": "4.10.0.1",
+	"version": "4.10.0.2",
 	"downloadFileNames": {
 		"Windows_86": "win-x86-net7.0.zip",
 		"Windows_64": "win-x64-net7.0.zip",

diff --git a/extensions/mssql/package.json b/extensions/mssql/package.json
@@ -628,6 +628,11 @@
           "when": "connectionProvider == MSSQL && nodeType == Folder && objectType == Tables",
           "group": "inline@0"
         },
+        {
+          "command": "mssql.newDatabase",
+          "when": "connectionProvider == MSSQL && nodeType == Folder && objectType == Databases && config.workbench.enablePreviewFeatures",
+          "group": "inline@0"
+        },
         {
           "command": "mssql.newObject",
           "when": "connectionProvider == MSSQL && nodeType == Folder && objectType =~ /^(ServerLevelLogins|Users|ServerLevelServerRoles|ApplicationRoles|DatabaseRoles)$/ && config.workbench.enablePreviewFeatures",
@@ -1567,7 +1572,7 @@
   "dependencies": {
     "@microsoft/ads-extension-telemetry": "^3.0.1",
     "@microsoft/ads-service-downloader": "^1.2.1",
-    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.7",
+    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.8",
     "find-remove": "1.2.1",
     "vscode-languageclient": "5.2.1",
     "vscode-nls": "^4.0.0"

diff --git a/extensions/mssql/package.nls.json b/extensions/mssql/package.nls.json
@@ -91,7 +91,7 @@
 	"mssql.connectionOptions.authType.description": "Specifies the method of authenticating with SQL Server",
 	"mssql.connectionOptions.authType.categoryValues.sqlLogin": "SQL Login",
 	"mssql.connectionOptions.authType.categoryValues.integrated": "Windows Authentication",
-	"mssql.connectionOptions.authType.categoryValues.azureMFA": "Azure Active Directory - Universal with MFA support",
+	"mssql.connectionOptions.authType.categoryValues.azureMFA": "Microsoft Entra ID - Universal with MFA support",
 	"mssql.connectionOptions.userName.displayName": "User name",
 	"mssql.connectionOptions.userName.description": "Indicates the user ID to be used when connecting to the data source",
 	"mssql.connectionOptions.password.displayName": "Password",

diff --git a/extensions/mssql/src/objectManagement/interfaces.ts b/extensions/mssql/src/objectManagement/interfaces.ts
@@ -276,7 +276,7 @@ export const enum UserType {
 	 */
 	SqlAuthentication = 'SqlAuthentication',
 	/**
-	 * Authenticate with Azure Active Directory.
+	 * Authenticate with Microsoft Entra.
 	 */
 	AADAuthentication = 'AADAuthentication',
 	/**

diff --git a/extensions/mssql/src/objectManagement/localizedConstants.ts b/extensions/mssql/src/objectManagement/localizedConstants.ts
@@ -247,15 +247,15 @@ export const PermissionToConnectText = localize('objectManagement.login.permissi
 export const LoginLockedOutText = localize('objectManagement.login.lockedOutLabel', "Login is locked out");
 export const WindowsAuthenticationTypeDisplayText = localize('objectManagement.login.windowsAuthenticationType', "Windows Authentication");
 export const SQLAuthenticationTypeDisplayText = localize('objectManagement.login.sqlAuthenticationType', "SQL Authentication");
-export const AADAuthenticationTypeDisplayText = localize('objectManagement.login.aadAuthenticationType', "Azure Active Directory Authentication");
+export const AADAuthenticationTypeDisplayText = localize('objectManagement.login.aadAuthenticationType', "Microsoft Entra ID Authentication");
 export const OldPasswordCannotBeEmptyError = localize('objectManagement.login.oldPasswordCannotBeEmptyError', "Old password cannot be empty.");
 
 // User
 export const UserTypeText = localize('objectManagement.user.type', "Type");
 export const UserType_LoginMapped = localize('objectManagement.user.loginMapped', "Mapped to a server login");
 export const UserType_WindowsUser = localize('objectManagement.user.windowsUser', "Mapped to a Windows user/group");
 export const UserType_SqlAuthentication = localize('objectManagement.user.sqlAuth', "Authenticate with password");
-export const UserType_AADAuthentication = localize('objectManagement.user.aadAuth', "Authenticate with Azure Active Directory");
+export const UserType_AADAuthentication = localize('objectManagement.user.aadAuth', "Authenticate with Microsoft Entra");
 export const UserType_NoLoginAccess = localize('objectManagement.user.noLogin', "No Login Access");
 export const DefaultSchemaText = localize('objectManagement.user.defaultSchemaLabel', "Default schema");
 export const LoginText = localize('objectManagement.user.loginLabel', "Login");

diff --git a/extensions/mssql/src/objectManagement/ui/attachDatabaseDialog.ts b/extensions/mssql/src/objectManagement/ui/attachDatabaseDialog.ts
@@ -62,16 +62,20 @@ export class AttachDatabaseDialog extends ObjectManagementDialogBase<Database, D
 		const buttonContainer = this.addButtonsForTable(this._databasesTable, addButton, removeButton);
 
 		this._nameField = this.createInputBox(async newValue => {
-			let selectedRow = this._databasesTable.selectedRows[0];
-			let dbFile = this._databasesToAttach[selectedRow];
-			dbFile.databaseName = newValue;
+			if (this._databasesTable.selectedRows?.length > 0) {
+				let selectedRow = this._databasesTable.selectedRows[0];
+				let dbFile = this._databasesToAttach[selectedRow];
+				dbFile.databaseName = newValue;
+			}
 		}, {});
 		this._nameContainer = this.createLabelInputContainer(loc.AttachAsText, this._nameField);
 
 		this._ownerDropdown = this.createDropdown(loc.OwnerText, async newValue => {
-			let selectedRow = this._databasesTable.selectedRows[0];
-			let dbFile = this._databasesToAttach[selectedRow];
-			dbFile.owner = newValue;
+			if (this._databasesTable.selectedRows?.length > 0) {
+				let selectedRow = this._databasesTable.selectedRows[0];
+				let dbFile = this._databasesToAttach[selectedRow];
+				dbFile.owner = newValue;
+			}
 		}, this.viewInfo.loginNames.options, this.viewInfo.loginNames.options[this.viewInfo.loginNames.defaultValueIndex]);
 		this._ownerContainer = this.createLabelInputContainer(loc.OwnerText, this._ownerDropdown);
 

diff --git a/extensions/mssql/src/objectManagement/ui/databaseDialog.ts b/extensions/mssql/src/objectManagement/ui/databaseDialog.ts
@@ -740,8 +740,9 @@ export class DatabaseDialog extends ObjectManagementDialogBase<Database, Databas
 				defaultFileGrowthInMb: defaultFileGrowthInMb,
 				defaultFileGrowthInPercent: defaultFileGrowthInPercent,
 				defaultMaxFileSizeLimitedToInMb: defaultMaxFileSizeLimitedToInMb
-			}
-		});
+			},
+			connectionUri: this.options.connectionUri
+		}, this.objectManagementService);
 		await dialog.open();
 		return await dialog.waitForClose();
 	}

diff --git a/extensions/mssql/src/objectManagement/ui/databaseFileDialog.ts b/extensions/mssql/src/objectManagement/ui/databaseFileDialog.ts
@@ -4,13 +4,13 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as azdata from 'azdata';
-import * as vscode from 'vscode';
 import * as path from 'path';
 import { DefaultInputWidth, DialogBase } from '../../ui/dialogBase';
 import * as localizedConstants from '../localizedConstants';
 import { DatabaseFile, DatabaseViewInfo, FileGrowthType } from '../interfaces';
 import { isUndefinedOrNull } from '../../types';
 import { deepClone } from '../../util/objects';
+import { IObjectManagementService } from 'mssql';
 
 export interface NewDatabaseFileDialogOptions {
 	title: string;
@@ -27,6 +27,7 @@ export interface NewDatabaseFileDialogOptions {
 		defaultFileGrowthInMb: number,
 		defaultMaxFileSizeLimitedToInMb: number
 	};
+	connectionUri: string;
 }
 
 const fileSizeInputMaxValueInMbForDataType = 16776192; // Row type supports up to 16 TB (SSMS allows =~ 15.99TB)
@@ -58,7 +59,7 @@ export class DatabaseFileDialog extends DialogBase<DatabaseFile> {
 	private originalFileName: string;
 	private isEditingFile: boolean;
 
-	constructor(private readonly options: NewDatabaseFileDialogOptions) {
+	constructor(private readonly options: NewDatabaseFileDialogOptions, private readonly objectManagementService: IObjectManagementService) {
 		super(options.title, 'DatabaseFileDialog');
 	}
 
@@ -296,23 +297,12 @@ export class DatabaseFileDialog extends DialogBase<DatabaseFile> {
 	 * Creates a file browser and sets the path to the filePath
 	 */
 	private async createFileBrowser(): Promise<void> {
-		let fileUris = await vscode.window.showOpenDialog(
-			{
-				canSelectFiles: false,
-				canSelectFolders: true,
-				canSelectMany: false,
-				defaultUri: vscode.Uri.file(this.options.databaseFile.path),
-				openLabel: localizedConstants.SelectText
-			}
-		);
-
-		if (!fileUris || fileUris.length === 0) {
-			return;
+		let dataFolder = await this.objectManagementService.getDataFolder(this.options.connectionUri);
+		let filePath = await azdata.window.openServerFileBrowserDialog(this.options.connectionUri, dataFolder, [{ label: localizedConstants.allFiles, filters: ['*'] }], true);
+		if (filePath?.length > 0) {
+			this.filePathTextBox.value = filePath;
+			this.result.path = filePath;
 		}
-
-		let fileUri = fileUris[0];
-		this.filePathTextBox.value = fileUri.fsPath;
-		this.result.path = fileUri.fsPath;
 	}
 
 	/**
@@ -332,7 +322,7 @@ export class DatabaseFileDialog extends DialogBase<DatabaseFile> {
 		if (selectedOption === localizedConstants.LogFiletype) {
 			fileGroupDdOptions = [localizedConstants.FileGroupForLogTypeText];
 			fileGroupDdValue = localizedConstants.FileGroupForLogTypeText;
-			fileSizeInputMaxValue = fileSizeInputMaxValueInMbForLogType
+			fileSizeInputMaxValue = fileSizeInputMaxValueInMbForLogType;
 		}
 		// File Stream
 		else if (selectedOption === localizedConstants.FilestreamFileType) {

diff --git a/extensions/mssql/src/objectManagement/ui/serverPropertiesDialog.ts b/extensions/mssql/src/objectManagement/ui/serverPropertiesDialog.ts
@@ -661,21 +661,8 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
 	}
 
 	public async selectFolder(location: string): Promise<string | undefined> {
-		const allFilesFilter = localizedConstants.allFiles;
-		let filter: any = {};
-		filter[allFilesFilter] = '*';
-		let uris = await vscode.window.showOpenDialog({
-			filters: filter,
-			canSelectFiles: false,
-			canSelectMany: false,
-			canSelectFolders: true,
-			defaultUri: vscode.Uri.file(location),
-			openLabel: localizedConstants.labelSelectFolder
-		});
-		if (uris && uris.length > 0) {
-			return uris[0].fsPath;
-		}
-		return undefined;
+		let dataFolder = await this.objectManagementService.getDataFolder(this.options.connectionUri);
+		return await azdata.window.openServerFileBrowserDialog(this.options.connectionUri, dataFolder, [{ label: localizedConstants.allFiles, filters: ['*'] }], true);
 	}
 
 	private initializeAdvancedSection(): void {

diff --git a/extensions/mssql/yarn.lock b/extensions/mssql/yarn.lock
@@ -511,9 +511,9 @@ crypt@~0.0.1:
   resolved "https://registry.yarnpkg.com/crypt/-/crypt-0.0.2.tgz#88d7ff7ec0dfb86f713dc87bbb42d044d3e6c41b"
   integrity sha1-iNf/fsDfuG9xPch7u0LQRNPmxBs=
 
-"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.7":
-  version "1.3.7"
-  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/0f07d03394eeebc2924971746470ac8224348fa4"
+"dataprotocol-client@github:Microsoft/sqlops-dataprotocolclient#1.3.8":
+  version "1.3.8"
+  resolved "https://codeload.github.com/Microsoft/sqlops-dataprotocolclient/tar.gz/828b7a5e5c1c077a0f6eb7f6acecd191fbaae13d"
   dependencies:
     vscode-languageclient "5.2.1"
 

diff --git a/extensions/sql-migration/package.json b/extensions/sql-migration/package.json
@@ -162,7 +162,7 @@
     ]
   },
   "dependencies": {
-    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.7",
+    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#1.3.8",
     "@microsoft/ads-service-downloader": "^1.2.1",
     "@microsoft/ads-extension-telemetry": "^3.0.1",
     "uuid": "^8.3.2",