Fix email comparisons to be case insensitive (#25330)

microsoft · Feb 16, 2024 · 2452651 · 2452651
1 parent 8a715ed
commit 2452651
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/sql/workbench/services/accountManagement/browser/accountManagementService.ts b/src/sql/workbench/services/accountManagement/browser/accountManagementService.ts
@@ -625,7 +625,7 @@ export class AccountManagementService implements IAccountManagementService {
 		let indexToRemove: number = accounts.findIndex(account => {
 			// corner case handling for personal accounts
 			if (account.key.accountId.includes('#') || accountToFind.key.accountId.includes('#')) {
-				return account.displayInfo.email === accountToFind.displayInfo.email;
+				return account.displayInfo.email.toLocaleLowerCase() === accountToFind.displayInfo.email.toLocaleLowerCase();
 			}
 			// MSAL account added
 			if (accountToFind.key.accountId.includes('.')) {

diff --git a/src/sql/workbench/services/connection/browser/connectionManagementService.ts b/src/sql/workbench/services/connection/browser/connectionManagementService.ts
@@ -1072,7 +1072,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
 		const azureAccounts = accounts.filter(a => a.key.providerId.startsWith('azure'));
 		if (azureAccounts && azureAccounts.length > 0) {
 			let accountId = (connection.authenticationType === Constants.AuthenticationType.AzureMFA || connection.authenticationType === Constants.AuthenticationType.AzureMFAAndUser) ? connection.azureAccount ?? connection.userName : connection.userName;
-			let account = azureAccounts.find(account => account.key.accountId === accountId || account.displayInfo.email === accountId);
+			let account = azureAccounts.find(account => account.key.accountId === accountId || account.displayInfo.email.toLocaleLowerCase() === accountId.toLocaleLowerCase());
 			if (account) {
 				this._logService.debug(`Getting security token for Azure account ${account.key.accountId}`);
 				if (account.isStale) {