Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Add option --baseurl to override default endpoint #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option --baseurl to override default endpoint #55

wants to merge 1 commit into from

Conversation

iwinux
Copy link

@iwinux iwinux commented Nov 18, 2018

related issue: #43

Copy link

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except comment.

@@ -15,14 +15,18 @@ import (
"github.com/Microsoft/azure-vhd-utils/vhdcore/common"
"github.com/Microsoft/azure-vhd-utils/vhdcore/diskstream"
"github.com/Microsoft/azure-vhd-utils/vhdcore/validator"
"gopkg.in/urfave/cli.v1"
cli "gopkg.in/urfave/cli.v1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? It should be usable under just v1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants