Fix End Game Issues #4681
Merged
Fix End Game Issues #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Flanker32
commented
Oct 26, 2020
Flanker32
commented
- Remove unsupported Windows JBoss 7.2 runtime, fxes https://dev.azure.com/mseng/VSJava/_workitems/edit/1786825
- Fix whats new manager issue and reduce document size, fixes https://dev.azure.com/mseng/VSJava/_workitems/edit/1786832/
- Fix VM module will always list all subscription, fixes https://dev.azure.com/mseng/VSJava/_workitems/edit/1786833
- Fix artifact combobox sync before run tasks issue, fixes https://dev.azure.com/mseng/VSJava/_workitems/edit/1786831
| @@ -69,14 +69,14 @@ public void setFileFilter(final Condition<? super VirtualFile> filter) { | |||
| this.fileFilter = filter; | |||
| } | |||
|
|
|||
| public synchronized void refreshItems(AzureArtifactType defaultArtifactType, String artifactIdentifier) { | |||
| public synchronized void refreshItems(AzureArtifact defaultArtifact) { | |||
There was a problem hiding this comment.
seems can be simplified by reusing super's setValue method,
let's consider refactor this part in next release.
wangmingliang-ms
approved these changes
Oct 26, 2020
Flanker32
force-pushed
the
hanxiao/fix
branch
from
2647f68 to
20317e2
Compare
wangmingliang-ms
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.