New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential infinity loop issue #2590

Merged

t-rufang merged 1 commit into microsoft:develop from t-rufang:issue_2567

Dec 29, 2018

Contributor

t-rufang commented Dec 29, 2018 •

edited

Loading

if A() <- B() means method B is refered in method A. We have:

In class RefreshableNode, load(boolean forceRefresh) <- refreshItems(SettableFuture<List<Node>> future, boolean forceRefresh) <- refreshItems()
In class ClusterNode, refreshItems() <- load(boolean forceRefresh).
Here infinity loop happends.


          Fix potentially infinity loop issue

43a0f54

t-rufang added this to the v3.17.0 milestone

t-rufang changed the title ~~Fix potentially infinity loop issue~~ Fix potential infinity loop issue

wezhang approved these changes

View reviewed changes

t-rufang merged commit 1145bbc into microsoft:develop

Contributor Author

t-rufang commented Dec 29, 2018

t-rufang deleted the issue_2567 branch

January 8, 2020 07:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet