Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoSuchElementException when refresh HDInsight storage account node #2575

Merged
merged 2 commits into from
Dec 28, 2018
Merged

Fix NoSuchElementException when refresh HDInsight storage account node #2575

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3424d4f
Fix NoSuchElementException when refresh HDInsight storage account node
t-rufang Dec 27, 2018
bba119c
Merge branch 'develop' into issue_2392
t-rufang Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions ...mon/src/com/microsoft/azure/hdinsight/serverexplore/hdinsightnode/StorageAccountNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
package com.microsoft.azure.hdinsight.serverexplore.hdinsightnode;

import com.microsoft.azure.hdinsight.common.CommonConst;
import com.microsoft.azure.hdinsight.common.logger.ILogger;
import com.microsoft.azure.hdinsight.sdk.storage.HDStorageAccount;
import com.microsoft.azure.hdinsight.sdk.storage.IHDIStorageAccount;
import com.microsoft.azure.hdinsight.sdk.storage.StorageAccountTypeEnum;
Expand All @@ -32,21 +33,24 @@
import com.microsoft.azure.storage.blob.CloudBlobContainer;
import com.microsoft.azuretools.azurecommons.helpers.AzureCmdException;
import com.microsoft.azuretools.azurecommons.helpers.NotNull;
import com.microsoft.azuretools.azurecommons.helpers.Nullable;
import com.microsoft.azuretools.azurecommons.helpers.StringHelper;
import com.microsoft.azuretools.telemetry.AppInsightsConstants;
import com.microsoft.azuretools.telemetry.TelemetryProperties;
import com.microsoft.tooling.msservices.model.storage.BlobContainer;
import com.microsoft.tooling.msservices.serviceexplorer.Node;
import com.microsoft.tooling.msservices.serviceexplorer.RefreshableNode;
import org.apache.commons.lang3.exception.ExceptionUtils;

import java.net.URISyntaxException;
import java.security.InvalidKeyException;
import java.util.*;
import java.util.Calendar;
import java.util.GregorianCalendar;
import java.util.HashMap;
import java.util.Map;
import java.util.stream.Stream;
import java.util.stream.StreamSupport;

public class StorageAccountNode extends RefreshableNode implements TelemetryProperties {
public class StorageAccountNode extends RefreshableNode implements TelemetryProperties, ILogger {
private static final String STORAGE_ACCOUNT_MODULE_ID = StorageAccountNode.class.getName();
private static final String ICON_PATH = CommonConst.StorageAccountIConPath;
private static final String ADLS_ICON_PATH = CommonConst.ADLS_STORAGE_ACCOUNT_ICON_PATH;
Expand Down Expand Up @@ -103,9 +107,14 @@ protected void refreshItems()
HDStorageAccount blobStorageAccount = (HDStorageAccount)storageAccount;
String defaultContainer = blobStorageAccount.getDefaultContainer();
final String connectionString = ((HDStorageAccount) storageAccount).getConnectionString();
getBlobContainers(connectionString).forEach(blobContainer -> {
addChildNode(new BlobContainerNode(this, blobStorageAccount, blobContainer, !StringHelper.isNullOrWhiteSpace(defaultContainer) && defaultContainer.equals(blobContainer.getName())));
});
try {
getBlobContainers(connectionString).forEach(blobContainer -> {
addChildNode(new BlobContainerNode(this, blobStorageAccount, blobContainer, !StringHelper.isNullOrWhiteSpace(defaultContainer) && defaultContainer.equals(blobContainer.getName())));
});
} catch (Exception ex) {
log().warn("refresh HDInsight storage account node failed. " + ExceptionUtils.getStackTrace(ex));
throw new AzureCmdException(ex.getCause().getMessage(), ex.getCause());
}
} else if(storageAccount.getAccountType() == StorageAccountTypeEnum.ADLS) {
// TODO adls support
}
Expand Down