Provide API createWebAppOnLinux to create web apps on linux #1963
Conversation
|
|
||
| AppServicePlan.DefinitionStages.WithPricingTier withPricingTier; | ||
| String resourceGroup = model.getResourceGroup(); | ||
| if (isCreatingNewResourceGroup) { |
There was a problem hiding this comment.
Move boolean isCreatingNewResourceGroup = model.isCreatingResGrp(); here
There was a problem hiding this comment.
Remove the variable declaration since it is used only once, check model.isCreatingResGrp() directly
| AppServicePlan.DefinitionStages.WithPricingTier withPricingTier; | ||
| String resourceGroup = model.getResourceGroup(); | ||
| if (isCreatingNewResourceGroup) { | ||
| withPricingTier = withGroup.withNewResourceGroup(resourceGroup); |
There was a problem hiding this comment.
Is it possible to check if the resource group exists or not?
There was a problem hiding this comment.
Will check and handle it during validation in next PR
| return appWithGroup.withExistingResourceGroup(resourceGroup).withNewWindowsPlan(withCreatePlan); | ||
| } | ||
|
|
||
| private WebApp.DefinitionStages.WithDockerContainerImage withCreateNewLinuxServicePlan( |
There was a problem hiding this comment.
Duplicated codes compared with withCreateNewWindowsServicePlan().
There was a problem hiding this comment.
Use helper methods to handle the duplicated codes.
| @@ -48,6 +50,8 @@ | |||
| private String region = ""; | |||
| private String pricing = ""; | |||
| private JavaVersion jdkVersion = JavaVersion.JAVA_8_NEWEST; | |||
| private RuntimeStack linuxRuntime = RuntimeStack.TOMCAT_8_5_JRE8; | |||
| private OperatingSystem os; | |||
There was a problem hiding this comment.
Why not assign a default value for consistency?
There was a problem hiding this comment.
@Matthew-Dong Any suggestions for the default value? Linux or Windows?
|
@Eskibear final String[] tierSize = model.getPricing().split("_");
if (tierSize.length != 2) {
throw new Exception("Cannot get valid price tier");
} |
|
Suggest to create an issue for using customized Error type instead of the general |
Fix the issue #1971
Use help methods
prepareWithCreateandprepareServicePlanto handle duplicate codes during creating a new Windows or Linux service plan.Add new API
createWebAppOnLinux.