Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better naming the create web app related functions #1949

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Better naming the create web app related functions #1949

merged 3 commits into from
Sep 6, 2018

Conversation

SummerSun
Copy link
Contributor

@SummerSun SummerSun commented Sep 5, 2018 •
edited
Loading

Better naming createWebAppOnLinux to createWebAppWithPrivateRegistryImage to specifically describe what this function does.

Better naming createWebApp to createWebAppOnWindows since it creates windows kind of web app.

To prepare for real API of creating web app on Linux.

@SummerSun SummerSun requested review from Eskibear and jdneo September 5, 2018 07:22
@SummerSun SummerSun changed the title Better naming the creat web app related functions Better naming the create web app related functions Sep 6, 2018
Eskibear
Eskibear requested changes Sep 6, 2018
View reviewed changes
Copy link
Member

@Eskibear Eskibear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

~~~The API is also used by~~~
~~~`\PluginsAndFeatures\azure-toolkit-for-eclipse\com.microsoft.azuretools.webapp\src\com\microsoft\azuretools\webapp\ui\AppServiceCreateDialog.java`~~~

Eskibear
Eskibear requested changes Sep 6, 2018
View reviewed changes
.../azuretools-core/src/com/microsoft/azuretools/core/mvp/model/webapp/AzureWebAppMvpModel.java Outdated
*/
public WebApp createWebApp(@NotNull WebAppSettingModel model) throws Exception {
public WebApp createWebAppOnWindows(@NotNull WebAppSettingModel model) throws Exception {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not matched with JavaDoc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IOException vs Exception

Eskibear
Eskibear approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SummerSun SummerSun merged commit 1eeacd6 into microsoft:develop Sep 6, 2018
@SummerSun SummerSun deleted the betternaming branch September 6, 2018 10:10
@SummerSun
Copy link
Contributor Author

Preparation of fixing issue #1971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eskibear Eskibear Eskibear approved these changes

@jdneo jdneo Awaiting requested review from jdneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SummerSun @Eskibear