Consume most recent task-lib in copyfiles #9390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damccorm
requested review from
stephenmichaelf
and removed request for
ericsciple
| @@ -16,7 +16,11 @@ let flattenFolders: boolean = tl.getBoolInput('flattenFolders', false); | |||
| // determine the relative path of each found file (substring using sourceFolder.length). | |||
| sourceFolder = path.normalize(sourceFolder); | |||
|
|
|||
| let allPaths: string[] = tl.find(sourceFolder); // default find options (follow sym links) | |||
| // Default find options except for allowing broken sym links. | |||
There was a problem hiding this comment.
Does this change behavior or keep it the same? Do we have tests to cover this?
There was a problem hiding this comment.
The only difference in behavior is that it allows broken symlinks (doesn't throw when it encounters one). We don't have coverage here, we do in the task-lib itself though. IMO it doesn't feel like this task's responsibility to test that specific functionality and testing broken symlinks is kinda gross so I think its fine, thoughts?
|
Closing this one for a bit since the code has shifted since its been opened, need to readdress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While all other task-lib functions used by DeleteFilesV1 haven't changed significantly, tl.match() has (it used to use semver and now it does its own matching). I think this should resolve #9231 and resolve #9046
EDIT: Also allows broken symlinks, should fix #9768 as well