Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NuGetCommandV2 to NodeJS10 #16826

Merged
merged 17 commits into from
Sep 8, 2022
Merged

Conversation

tintse-thxsky-MSFT
Copy link
Contributor

@tintse-thxsky-MSFT tintse-thxsky-MSFT commented Aug 31, 2022

Task name:

Description:

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@tintse-thxsky-MSFT
Copy link
Contributor Author

azp/run

@aasim aasim self-requested a review September 6, 2022 18:35
Copy link
Member

@aasim aasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

@tintse-thxsky-MSFT
Copy link
Contributor Author

@KonstantinTyukalov Hi I don't know if you are the right person for the code owner/team for make-util.js. But if you, can you review it and approve it/leave a comment?

@tintse-thxsky-MSFT tintse-thxsky-MSFT requested a review from a team September 6, 2022 19:50
@tintse-thxsky-MSFT tintse-thxsky-MSFT merged commit d54de00 into master Sep 8, 2022
@tintse-thxsky-MSFT tintse-thxsky-MSFT deleted the nugetcommandnode10 branch September 8, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants